Expand pool.name in semantic conventions#3050
Merged
carlosalberto merged 24 commits intoopen-telemetry:mainfrom Mar 3, 2023
Merged
Expand pool.name in semantic conventions#3050carlosalberto merged 24 commits intoopen-telemetry:mainfrom
carlosalberto merged 24 commits intoopen-telemetry:mainfrom
Conversation
according to the discussion here: open-telemetry#3038 I'm updating the `pool.name attribute`
arminru
reviewed
Dec 20, 2022
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
add commas + quote marks.
Closed
mateuszrzeszutek
approved these changes
Jan 2, 2023
Member
Author
|
Hi, Can someone do a CR please? (I already have one approval from Mateus) |
Member
Author
|
@open-telemetry/specs-metrics-approvers Hi again, this PR was already stale and I don't want it to be close. |
arminru
reviewed
Jan 31, 2023
add commas to the example string Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Use db.connection_string as a fallback in case we don't have the name of the pool.
mateuszrzeszutek
approved these changes
Feb 9, 2023
rephrase Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Contributor
|
@open-telemetry/specs-approvers please review. There was a last cycle of feedback applied, so this should look better. |
1 task
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Member
Author
|
Hi, |
jsuereth
approved these changes
Mar 1, 2023
Contributor
|
@haddasbronfman Once the markup is fixed (as @jsuereth mentioned), we are ready to merge. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
according to the discussion here: open-telemetry#3038 I'm updating the `pool.name attribute`
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
according to the discussion here: open-telemetry#3038 I'm updating the `pool.name attribute`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to the discussion here: #3038 I'm updating the
pool.name attribute