Skip to content

Allow recording links only at Span creation time#258

Merged
bogdandrutu merged 5 commits intoopen-telemetry:masterfrom
bogdandrutu:rmaddlink
Sep 24, 2019
Merged

Allow recording links only at Span creation time#258
bogdandrutu merged 5 commits intoopen-telemetry:masterfrom
bogdandrutu:rmaddlink

Conversation

@bogdandrutu
Copy link
Copy Markdown
Member

Remove addLink support from the Span API and allow only during Span creation.

For more details about why see https://github.com/open-telemetry/oteps/blob/master/text/0006-sampling.md#links

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu and others added 3 commits September 24, 2019 08:49
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
@bogdandrutu bogdandrutu merged commit 1b7bfd8 into open-telemetry:master Sep 24, 2019
@bogdandrutu bogdandrutu deleted the rmaddlink branch September 24, 2019 17:17
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
* Allow recording links only at Span creation time

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix grammar for attributes during span creation

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/api-tracing.md

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>

* Update specification/api-tracing.md

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>

* Fix some links to the add-links
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this pull request Oct 15, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 23, 2024
…ion (open-telemetry#258)

Based on conversations last week in the Specification and Semantic
Conventions SIGs, I'm opening this duplicate pull request which was
originally set as a
[Draft](https://github.com/open-telemetry/oteps/pull/241/files) and
hasn't had movement since last November.

There are real use cases that are coming to fruiting, namely in the
CI/CD working group, that will benefit from this being accepted. Once
accepted we can work on getting the specification added for both general
context propagation and baggage.

On the note of baggage; baggage is a form of context propagation and was
not originally mentioned directly by name in this OTEP. It is however,
absolutely essential. I've had the pleasure of prototyping out tracing
within an OpenTofu controller system where context on available in
parent/child at the very start of the trace was available. Baggage was
the means of transferring this critical context to subsequent siblings
that would've not had it otherwise.

Thanks for all the hard work to the original author (@deejgregor) and
opening the draft open-telemetry#241

CC. TC sponsors @jsuereth @carlosalberto

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Allow recording links only at Span creation time

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix grammar for attributes during span creation

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/api-tracing.md

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>

* Update specification/api-tracing.md

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>

* Fix some links to the add-links
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…ion (open-telemetry#258)

Based on conversations last week in the Specification and Semantic
Conventions SIGs, I'm opening this duplicate pull request which was
originally set as a
[Draft](https://github.com/open-telemetry/oteps/pull/241/files) and
hasn't had movement since last November.

There are real use cases that are coming to fruiting, namely in the
CI/CD working group, that will benefit from this being accepted. Once
accepted we can work on getting the specification added for both general
context propagation and baggage.

On the note of baggage; baggage is a form of context propagation and was
not originally mentioned directly by name in this OTEP. It is however,
absolutely essential. I've had the pleasure of prototyping out tracing
within an OpenTofu controller system where context on available in
parent/child at the very start of the trace was available. Baggage was
the means of transferring this critical context to subsequent siblings
that would've not had it otherwise.

Thanks for all the hard work to the original author (@deejgregor) and
opening the draft open-telemetry#241

CC. TC sponsors @jsuereth @carlosalberto

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants