refactor: parametrize tests#3256
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
=======================================
- Coverage 82.9% 82.9% -0.1%
=======================================
Files 130 130
Lines 27386 27350 -36
=======================================
- Hits 22711 22675 -36
Misses 4675 4675 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I asked Claude to see if there are many others here we could pick up. Not sure how useful this is, but it's probably worth trying to pick out other instances of this pattern we can clean up!
|
|
@chickenbreeder let me know when you are ready with this! |
|
Hey @chickenbreeder , did you want to do more of these, or should we review it as it is? |
|
Hey @scottgerring. Sorry, I did not get around to do any further work on this. |
|
Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience. It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open. |
|
Closed as inactive. Thank you again for the contribution; please feel free to reopen this PR (or open a new one) if you'd like to continue the work. |
|
As we worked on this together at a hackathon earlier this year, it would be cool to see this merged. I'll try rebase against main this week. |
scottgerring
left a comment
There was a problem hiding this comment.
Thanks @chickenbreeder ! This gets us started with parameterized tests; it doesn't cover everything ofc, but we should merge it.
Pinging @cijothomas to get on the queue
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Fixes #1552
Changes
rstestversion to no longer depend on async-std by default (See: fix: do not depend by default onasync-stdla10736/rstest#311); this issue only occurred in the context ofMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes