Move all DD code into its own directory#6
Move all DD code into its own directory#6codeboten merged 1 commit intoopen-telemetry:masterfrom ocelotl:issue_3
Conversation
codeboten
left a comment
There was a problem hiding this comment.
Thanks for taking on this work. One change I'd like to request is that this change is doing more than moving dd code, those changes would be better done separately, otherwise it makes it hard to know what's changed.
One question: is there a reason to add the opentelemetry-auto-instrumentation code in this repo? I thought that would continue to live in the main opentelemetry-python repo.
codeboten
left a comment
There was a problem hiding this comment.
Can you add a comment in the README regarding the initial code being available as reference in the reference branch? This would help folks taking a look at the repo for the first time. A few files were deleted that shouldn't be. Please fix.
Thanks for the review, I have added the changes 👍 |
|
Had a chat with @ocelotl @codeboten and @mauriciovasquezbernal and we're going to pause on this PR to make the porting of the instrumentation PRs easier. |
* Add .pylintrc based on OpenCensus (related open-telemetry#6). * Fix/disable pylint warnings. * pylint: Fix W0107: Unnecessary pass statement (unnecessary-pass) I'm not sure I like this warning.
* Add .pylintrc based on OpenCensus (related open-telemetry#6). * Fix/disable pylint warnings. * pylint: Fix W0107: Unnecessary pass statement (unnecessary-pass) I'm not sure I like this warning.
Move all DD code into its own directory. This is done to keep the code close at hand for instrumentor development.
Fixes #3