fix missing dep in docs build#557
Merged
codeboten merged 7 commits intoopen-telemetry:mainfrom Jun 30, 2021
Merged
Conversation
owais
approved these changes
Jun 29, 2021
NathanielRN
approved these changes
Jun 29, 2021
Contributor
NathanielRN
left a comment
There was a problem hiding this comment.
This definitely looks like a good step towards fixing the docs build! It answers the question in the error log we see in #552.
I'm wondering if the docs will need 0pentelemetry-semantic-conventions too... In this PR where I updated to OTel Python v1.3 I had to add it along with the following packages:
util/opentelemetry-util-httpexporter/opentelemetry-exporter-otlp-proto-grpc
Either way if the error changes we'll know what to do 🙂
Contributor
Author
Those will be installed as a dependency of installing the sdk. |
lzchen
approved these changes
Jun 30, 2021
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 1, 2021
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 1, 2021
This reverts commit 5a0557f.
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 1, 2021
This reverts commit 5a0557f.
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 12, 2021
This reverts commit 5a0557f.
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 22, 2021
This reverts commit 5a0557f.
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 22, 2021
This reverts commit 5a0557f.
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
docs-requirements.txt was missing an important dependency at build time.
Fixes #552
Type of change
Please delete options that are not relevant.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.