Remove span attributes pymemcache#4076
Merged
xrmx merged 12 commits intoopen-telemetry:mainfrom Jan 21, 2026
Merged
Conversation
|
|
herin049
reviewed
Jan 2, 2026
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Jan 13, 2026
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Show resolved
Hide resolved
Contributor
|
@saurabh-saraswat Thanks for the PR but in order to contribute to this project you need to sign the CLA |
xrmx
reviewed
Jan 20, 2026
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Jan 20, 2026
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Show resolved
Hide resolved
...elemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Jan 20, 2026
Contributor
|
@saurabh-saraswat please pull, |
wikaaaaa
pushed a commit
to wikaaaaa/opentelemetry-python-contrib
that referenced
this pull request
Feb 5, 2026
* opentelemetry-instrumentation-pymemcache: Remove usage of deprecated SpanAttributes * Fixed linting issues * Incorporated Review Comments for usage of NET_TRANSPORT * Added back the empty lines * Apply suggestions from code review * Update __init__.py * Update __init__.py * Update test_pymemcache.py * Executed tox --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
* opentelemetry-instrumentation-pymemcache: Remove usage of deprecated SpanAttributes * Fixed linting issues * Incorporated Review Comments for usage of NET_TRANSPORT * Added back the empty lines * Apply suggestions from code review * Update __init__.py * Update __init__.py * Update test_pymemcache.py * Executed tox --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces usage of the deprecated SpanAttributes with semconv constants.
Fixes #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ptox run -e $(tox --listenvs | grep memcache | tr '\n' ',')
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.