Support passing tracer provider in aiohttp server instrumentation lib by bisgaard-itis · Pull Request #3819 · open-telemetry/opentelemetry-python-contrib

bisgaard-itis · 2025-10-08T10:44:32Z

Description

Support passing a TracerProvider when using the aiohttp server instrumentation library. This gives users of the library the possibility to provide their own TracerProvider instead of relying on the global one. This is in particular useful for testing.

Fixes # (issue)

resolves Allow passing a TracerProvider when instrumenting an aiohttp server #3801

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I added the test test_non_global_tracer_provider which checks that a non-global TracerProvider can be provided when instrumenting the aiohttp server. I check that the non-global TracerProvider is used by the instrumentation library by setting a non-default sampling probability in that provider and checking that the corresponding number of traces are collected.

Does This PR Require a Core Repo Change?

Yes. - Link to PR:
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

linux-foundation-easycla · 2025-10-08T10:44:38Z

The committers listed above are authorized under a signed CLA.

✅ login: xrmx / name: Riccardo Magliocchetti (a2cd643, a4c8367)

xrmx · 2025-10-10T08:17:57Z

@bisgaard-itis You need to sign the CLA in order to contribute to OpenTelemetry, thanks.

bisgaard-itis · 2025-10-17T11:55:23Z

@bisgaard-itis You need to sign the CLA in order to contribute to OpenTelemetry, thanks.

Perfect, thanks a lot for pointing this out @xrmx. I have signed it.

bisgaard-itis · 2025-10-26T21:35:33Z

@krnr this PR has been hanging for some time. Can I convince you to to review it? 🙏🏻

krnr · 2025-10-27T13:39:27Z

@krnr this PR has been hanging for some time. Can I convince you to to review it? 🙏🏻

i see no issues, the code is pretty much straight-forward - the same middleware logic, but the middleware itself is created on-the-fly. i like it 👍

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

CHANGELOG.md

tammy-baylis-swi · 2025-10-28T21:53:05Z

Also:

precommit is failing; please run tox -e ruff on your local and commit changes.
Some aiohttp-server tests are failing, please take a look.

…lemetry#3875) * Only decode JSON input buffer in Anthropic Claude streaming _decode_tool_use was only used when _tool_json_input_buf was found, but we were decoding the entire _content_block after adding _tool_json_input_buf to it. The _content_block overall which could contain non-JSON elements (e.g. {}), causing failures. To fix this, we have removed _decode_tool_use helper function and inlined JSON decoding logic directly into content_block_stop handler in _process_anthropic_claude_chunk, where we only use it to decode _tool_json_input_buf before appending to _content_block. * Update test_botocore_bedrock.py Fix lint: `opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py:2990:4: C0415: Import outside toplevel (opentelemetry.instrumentation.botocore.extensions.bedrock_utils.InvokeModelWithResponseStreamWrapper) (import-outside-toplevel)` * Update test_botocore_bedrock.py Remove extra line * fix lint issue

* Stop using deprecated span.instrumentation_info * aiohttp-client: add support for OTEL_PYTHON_EXCLUDED_URLS / OTEL_PYTHON_HTTPX_EXCLUDED_URLS * Add docs * Add changelog * Please lint * Update CHANGELOG.md Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Test for both env vars * Assert at each iteration --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>

tammy-baylis-swi · 2025-11-14T18:09:05Z

Great, thanks a lot @tammy-baylis-swi. Do you know if I need to do anything to get a maintainer to review it?

Nothing needed since it's on the triage project board 👍 It just takes time since we're always in need of more contributors and approvers! If you do want to bring this PR up more synchronously, you can check out #otel-python on the CNCF Slack or attend the Thursday meetings (all linked here).

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

…acerProvider-in-aiohttp-server-instrumentation-lib

…tp-server-instrumentation-lib

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

@tammy-baylis-swi

…open-telemetry#3819) * allow to pass tracer_provider when instrumenting aiohttp server * minor fix * add note to indicate backwards compatibility * small fix * add test * update changelog * Only decode JSON input buffer in Anthropic Claude streaming (open-telemetry#3875) * Only decode JSON input buffer in Anthropic Claude streaming _decode_tool_use was only used when _tool_json_input_buf was found, but we were decoding the entire _content_block after adding _tool_json_input_buf to it. The _content_block overall which could contain non-JSON elements (e.g. {}), causing failures. To fix this, we have removed _decode_tool_use helper function and inlined JSON decoding logic directly into content_block_stop handler in _process_anthropic_claude_chunk, where we only use it to decode _tool_json_input_buf before appending to _content_block. * Update test_botocore_bedrock.py Fix lint: `opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py:2990:4: C0415: Import outside toplevel (opentelemetry.instrumentation.botocore.extensions.bedrock_utils.InvokeModelWithResponseStreamWrapper) (import-outside-toplevel)` * Update test_botocore_bedrock.py Remove extra line * fix lint issue * aiohttp-client: add support for url exclusions (open-telemetry#3850) * Stop using deprecated span.instrumentation_info * aiohttp-client: add support for OTEL_PYTHON_EXCLUDED_URLS / OTEL_PYTHON_HTTPX_EXCLUDED_URLS * Add docs * Add changelog * Please lint * Update CHANGELOG.md Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Test for both env vars * Assert at each iteration --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * update changelog * @tammy-baylis-swi add link to PR * create factory for instrumented application * run precommit hooks * update readthedocs * cleanup changelog after merge conflicts * make pre-commit happy * @tammy-baylis-swi add comment about optional inputs * fix issues caused by merge * precommit hooks * fix typehints * sort imports * @xrmx removed assert * Apply suggestions from code review --------- Co-authored-by: Thomas Pierce <thp@amazon.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>

@tammy-baylis-swi

…open-telemetry#3819) * allow to pass tracer_provider when instrumenting aiohttp server * minor fix * add note to indicate backwards compatibility * small fix * add test * update changelog * Only decode JSON input buffer in Anthropic Claude streaming (open-telemetry#3875) * Only decode JSON input buffer in Anthropic Claude streaming _decode_tool_use was only used when _tool_json_input_buf was found, but we were decoding the entire _content_block after adding _tool_json_input_buf to it. The _content_block overall which could contain non-JSON elements (e.g. {}), causing failures. To fix this, we have removed _decode_tool_use helper function and inlined JSON decoding logic directly into content_block_stop handler in _process_anthropic_claude_chunk, where we only use it to decode _tool_json_input_buf before appending to _content_block. * Update test_botocore_bedrock.py Fix lint: `opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py:2990:4: C0415: Import outside toplevel (opentelemetry.instrumentation.botocore.extensions.bedrock_utils.InvokeModelWithResponseStreamWrapper) (import-outside-toplevel)` * Update test_botocore_bedrock.py Remove extra line * fix lint issue * aiohttp-client: add support for url exclusions (open-telemetry#3850) * Stop using deprecated span.instrumentation_info * aiohttp-client: add support for OTEL_PYTHON_EXCLUDED_URLS / OTEL_PYTHON_HTTPX_EXCLUDED_URLS * Add docs * Add changelog * Please lint * Update CHANGELOG.md Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Test for both env vars * Assert at each iteration --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * update changelog * @tammy-baylis-swi add link to PR * create factory for instrumented application * run precommit hooks * update readthedocs * cleanup changelog after merge conflicts * make pre-commit happy * @tammy-baylis-swi add comment about optional inputs * fix issues caused by merge * precommit hooks * fix typehints * sort imports * @xrmx removed assert * Apply suggestions from code review --------- Co-authored-by: Thomas Pierce <thp@amazon.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>

@tammy-baylis-swi

…open-telemetry#3819) * allow to pass tracer_provider when instrumenting aiohttp server * minor fix * add note to indicate backwards compatibility * small fix * add test * update changelog * Only decode JSON input buffer in Anthropic Claude streaming (open-telemetry#3875) * Only decode JSON input buffer in Anthropic Claude streaming _decode_tool_use was only used when _tool_json_input_buf was found, but we were decoding the entire _content_block after adding _tool_json_input_buf to it. The _content_block overall which could contain non-JSON elements (e.g. {}), causing failures. To fix this, we have removed _decode_tool_use helper function and inlined JSON decoding logic directly into content_block_stop handler in _process_anthropic_claude_chunk, where we only use it to decode _tool_json_input_buf before appending to _content_block. * Update test_botocore_bedrock.py Fix lint: `opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py:2990:4: C0415: Import outside toplevel (opentelemetry.instrumentation.botocore.extensions.bedrock_utils.InvokeModelWithResponseStreamWrapper) (import-outside-toplevel)` * Update test_botocore_bedrock.py Remove extra line * fix lint issue * aiohttp-client: add support for url exclusions (open-telemetry#3850) * Stop using deprecated span.instrumentation_info * aiohttp-client: add support for OTEL_PYTHON_EXCLUDED_URLS / OTEL_PYTHON_HTTPX_EXCLUDED_URLS * Add docs * Add changelog * Please lint * Update CHANGELOG.md Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * Test for both env vars * Assert at each iteration --------- Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> * update changelog * @tammy-baylis-swi add link to PR * create factory for instrumented application * run precommit hooks * update readthedocs * cleanup changelog after merge conflicts * make pre-commit happy * @tammy-baylis-swi add comment about optional inputs * fix issues caused by merge * precommit hooks * fix typehints * sort imports * @xrmx removed assert * Apply suggestions from code review --------- Co-authored-by: Thomas Pierce <thp@amazon.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>

bisgaard-itis changed the title ~~3801 support passing tracer provider in aiohttp server instrumentation lib~~ Support passing tracer provider in aiohttp server instrumentation lib Oct 8, 2025

bisgaard-itis mentioned this pull request Oct 8, 2025

🚨✨ Implement tracing sampling strategy (🚧 devops 🚧) ITISFoundation/osparc-simcore#8421

Merged

xrmx added this to Python PR digest Oct 10, 2025

xrmx moved this to Reviewed PRs that need fixes in Python PR digest Oct 10, 2025

bisgaard-itis requested a review from a team as a code owner October 26, 2025 21:34

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py Show resolved Hide resolved

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py Outdated Show resolved Hide resolved

tammy-baylis-swi reviewed Oct 28, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

github-actions bot assigned codefromthecrypt, DylanRussell, karthikscale3, lzchen and nirga Nov 3, 2025

bisgaard-itis and others added 11 commits November 3, 2025 09:39

allow to pass tracer_provider when instrumenting aiohttp server

a54fdd3

minor fix

8772240

add note to indicate backwards compatibility

8021f70

small fix

09c4164

add test

7d1be5f

update changelog

07f833f

update changelog

a7b4a88

@tammy-baylis-swi add link to PR

a89c17f

create factory for instrumented application

b679ee1

xrmx unassigned codefromthecrypt, nirga, DylanRussell, lzchen and karthikscale3 Nov 28, 2025

xrmx reviewed Nov 28, 2025

View reviewed changes

...-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py Outdated Show resolved Hide resolved

xrmx moved this from Ready for review to Approved PRs that need fixes in Python PR digest Nov 28, 2025

Merge remote-tracking branch 'otel/main' into 3801-support-passing-Tr…

ca8ece2

…acerProvider-in-aiohttp-server-instrumentation-lib

bisgaard-itis force-pushed the 3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib branch from a934b0c to ca8ece2 Compare December 2, 2025 10:56

@xrmx removed assert

9af8e98

bisgaard-itis requested a review from xrmx December 2, 2025 11:01

bisgaard-itis added 2 commits December 4, 2025 09:50

Merge remote-tracking branch 'otel/main' into 3801-support-passing-Tr…

1d69fd8

…acerProvider-in-aiohttp-server-instrumentation-lib

Merge branch 'main' into 3801-support-passing-TracerProvider-in-aioht…

dd31778

…tp-server-instrumentation-lib

bisgaard-itis force-pushed the 3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib branch from b438f24 to dd31778 Compare December 15, 2025 08:36

Merge branch 'main' into 3801-support-passing-TracerProvider-in-aioht…

e39dd4d

…tp-server-instrumentation-lib

bisgaard-itis force-pushed the 3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib branch from 83fe32f to e39dd4d Compare December 19, 2025 07:04

bisgaard-itis and others added 3 commits December 19, 2025 11:28

Merge branch 'main' into 3801-support-passing-TracerProvider-in-aioht…

433cdd7

…tp-server-instrumentation-lib

Merge branch 'main' into 3801-support-passing-TracerProvider-in-aioht…

8a371d0

…tp-server-instrumentation-lib

Merge branch 'main' into 3801-support-passing-TracerProvider-in-aioht…

a4c8367

…tp-server-instrumentation-lib

xrmx reviewed Dec 22, 2025

View reviewed changes

Apply suggestions from code review

a2cd643

xrmx approved these changes Dec 22, 2025

View reviewed changes

xrmx merged commit 77373f8 into open-telemetry:main Dec 22, 2025
663 checks passed

github-project-automation bot moved this from Approved PRs that need fixes to Done in Python PR digest Dec 22, 2025

bisgaard-itis deleted the 3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib branch January 5, 2026 08:27

Cirilla-zmh mentioned this pull request Mar 5, 2026

chore: sync upstream/main into main alibaba/loongsuite-python-agent#125

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support passing tracer provider in aiohttp server instrumentation lib#3819

Support passing tracer provider in aiohttp server instrumentation lib#3819
xrmx merged 32 commits intoopen-telemetry:mainfrom
bisgaard-itis:3801-support-passing-TracerProvider-in-aiohttp-server-instrumentation-lib

bisgaard-itis commented Oct 8, 2025 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

xrmx commented Oct 10, 2025

Uh oh!

bisgaard-itis commented Oct 17, 2025

Uh oh!

bisgaard-itis commented Oct 26, 2025

Uh oh!

krnr commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tammy-baylis-swi commented Oct 28, 2025

Uh oh!

tammy-baylis-swi commented Nov 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

bisgaard-itis commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

linux-foundation-easycla bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xrmx commented Oct 10, 2025

Uh oh!

bisgaard-itis commented Oct 17, 2025

Uh oh!

bisgaard-itis commented Oct 26, 2025

Uh oh!

krnr commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tammy-baylis-swi commented Oct 28, 2025

Uh oh!

tammy-baylis-swi commented Nov 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bisgaard-itis commented Oct 8, 2025 •

edited

Loading

linux-foundation-easycla bot commented Oct 8, 2025 •

edited

Loading