requests: migrate from SpanAttributes#3493
Merged
xrmx merged 5 commits intoopen-telemetry:mainfrom May 19, 2025
IAmPrajna:main
Merged
requests: migrate from SpanAttributes#3493xrmx merged 5 commits intoopen-telemetry:mainfrom IAmPrajna:main
xrmx merged 5 commits intoopen-telemetry:mainfrom
IAmPrajna:main
Conversation
xrmx
reviewed
May 15, 2025
Contributor
xrmx
left a comment
There was a problem hiding this comment.
A couple of nits but the attributes changes look fine.
instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py
Outdated
Show resolved
Hide resolved
emdneto
approved these changes
May 15, 2025
Contributor
Author
|
I have sorted the imports. Can you please re-run the tests ? @xrmx |
xrmx
approved these changes
May 19, 2025
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
* ref: migrate from SpanAttributes * B reverted to SpanAttributes for the SCHEMA_URL * replace SpanAttributes.SCHEMA_URL * sort imports --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces usage of
SpanAttributeswithopentelemetry.semconv.attributes.http_attributesandopentelemetry.semconv._incubating.attributes.Refs #3475
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.