Skip to content

refactor(fastapi): replace uses of SpanAttributes with opentelemetry.semconv.attributes#3491

Merged
xrmx merged 6 commits intoopen-telemetry:mainfrom
TheShubhendra:main
May 19, 2025
Merged

refactor(fastapi): replace uses of SpanAttributes with opentelemetry.semconv.attributes#3491
xrmx merged 6 commits intoopen-telemetry:mainfrom
TheShubhendra:main

Conversation

@TheShubhendra
Copy link
Contributor

@TheShubhendra TheShubhendra commented May 10, 2025

Description

Replaces usage of SpanAttributes.HTTP_ROUTE with opentelemetry.semconv.attributes.http_attributes.HTTP_ROUTE as part of the migration away from SpanAttributes.

Refs #3475

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

…ntic conventions

Replaced usage of `SpanAttributes.HTTP_ROUTE` with `opentelemetry.semconv.attributes.http_attributes.HTTP_ROUTE`
as part of the migration away from `SpanAttributes`.

Refs: open-telemetry#3475
@xrmx xrmx mentioned this pull request May 11, 2025
42 tasks
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 15, 2025
@xrmx xrmx enabled auto-merge (squash) May 19, 2025 08:08
@xrmx xrmx merged commit ec73158 into open-telemetry:main May 19, 2025
719 of 720 checks passed
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…ry.semconv.attributes` (open-telemetry#3491)

* refactor(fastapi): migrate HTTP_ROUTE from SpanAttributes to new semantic conventions

Replaced usage of `SpanAttributes.HTTP_ROUTE` with `opentelemetry.semconv.attributes.http_attributes.HTTP_ROUTE`
as part of the migration away from `SpanAttributes`.

Refs: open-telemetry#3475

* refactor(fastapi): refactor tests

* refactor(fastapi): remove duplicated import

* sort imports

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants