Merged
Conversation
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
emdneto
commented
Jan 14, 2025
xrmx
approved these changes
Jan 14, 2025
Kludex
approved these changes
Jan 14, 2025
Member
Kludex
left a comment
There was a problem hiding this comment.
For curiosity, did you check how much performance benefit there is here?
Contributor
Completely unscientific but looks like on CI two test workflows out of three are a few minutes faster |
Member
|
Unscientific is good. I was lazy to look. 😐👍 Few minutes is great. |
lzchen
approved these changes
Jan 17, 2025
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
after some rework, I'm opening another PR with less intrusive changes to the tox.ini file. Basically, this is a new version of the work from #2667
uv makes pip install faster. It works like this:
uv pip installand we can have tests running faster locally and in CI. The tool is from the creators of ruff.The main improvement I see here is the Dependency caching and fast resolution of packages during pip install. We can benefit from this for local development to avoid slow tests, mainly the git clones in contrib tests.
This PR also introduces the usage of tox-uv which is a tox plugin that supports venv runner with uv.