HTTP semantic convention stability migration for urllib3#2715
Merged
lzchen merged 11 commits intoopen-telemetry:mainfrom Jul 23, 2024
Merged
HTTP semantic convention stability migration for urllib3#2715lzchen merged 11 commits intoopen-telemetry:mainfrom
lzchen merged 11 commits intoopen-telemetry:mainfrom
Conversation
Contributor
server.address , server.port Can probably create a separate issue for these. |
lzchen
reviewed
Jul 22, 2024
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Jul 22, 2024
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #2453
Fixes #2681
Checklist
migrationfor urllib3 in instrumentations README{method}asHTTPwhen nonstandard method (sanitize_method)_OTHERwhen nonstandard http method and for new semconv also sethttp.request.method_originalwith the original nonstandard method.At the current implementation, some of the required/recommended semconv span attributes aren't being set:
server.address,server.portnetwork.protocol.verison