Feature/metrics instrumentation urllib3#1198
Merged
srikanthccv merged 18 commits intoopen-telemetry:mainfrom Aug 9, 2022
Merged
Feature/metrics instrumentation urllib3#1198srikanthccv merged 18 commits intoopen-telemetry:mainfrom
srikanthccv merged 18 commits intoopen-telemetry:mainfrom
Conversation
lzchen
reviewed
Jul 21, 2022
instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py
Show resolved
Hide resolved
f13b4c7 to
1484ef0
Compare
3cad099 to
f4261ba
Compare
lzchen
approved these changes
Jul 26, 2022
srikanthccv
reviewed
Jul 26, 2022
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/version.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py
Outdated
Show resolved
Hide resolved
0f66541 to
56fb196
Compare
56fb196 to
471dadf
Compare
srikanthccv
suggested changes
Jul 28, 2022
Member
srikanthccv
left a comment
There was a problem hiding this comment.
I believe uninstrument should stop producing all telemetry including metrics. I am going to bring this up in today's SIG. Blocking the accidental merge meanwhile.
Contributor
|
Please update the metrics support for this instrumentation here |
Member
|
Add |
Member
|
@shalevr We will need tests to make sure |
fa9a8a5 to
fcb2d42
Compare
0bbc7a0 to
9db1dba
Compare
srikanthccv
reviewed
Aug 8, 2022
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py
Outdated
Show resolved
Hide resolved
added 2 commits
August 8, 2022 22:46
…hub.com/shalevr/opentelemetry-python-contrib into feature/Metrics-instrumentation-urllib3 * 'feature/Metrics-instrumentation-urllib3' of https://github.com/shalevr/opentelemetry-python-contrib: Metric instrumentation asgi (open-telemetry#1197) Metrics instrumentation flask (open-telemetry#1186) Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206)
srikanthccv
approved these changes
Aug 9, 2022
shalevr
pushed a commit
to shalevr/opentelemetry-python-contrib
that referenced
this pull request
Aug 30, 2022
* main: Codespell ci (open-telemetry#1237) aiohttp-client: Fix producing additional spans with each newly created ClientSession (open-telemetry#1246) Remove support for 3.6 (open-telemetry#853) Added the Licence and Manifest file Restore metrics in django (open-telemetry#1208) fix typo in example codes (open-telemetry#1240) boto3sqs: Make propagation compatible with other instrumentations and add 'messaging.url' span attribute (open-telemetry#1234) Release 1.12.0-0.33b0 (open-telemetry#1223) Fix Flask instrumentation doc link (open-telemetry#1216) Feature/metrics instrumentation urllib3 (open-telemetry#1198) Metric instrumentation asgi (open-telemetry#1197) Metrics instrumentation flask (open-telemetry#1186) Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206) ci: fix docs workflow failure (open-telemetry#1211) Add psycopg2 native tags to sqlcommenter (open-telemetry#1203) SQLCommenter semicolon bug fix (open-telemetry#1200) Sync with sdk setup from setUpClass to setUp (open-telemetry#1193) # Conflicts: # CHANGELOG.md # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add metrics instrumentation for urllib3
Fixes #1144
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.