Revisit OpenTracing Shim docs#925
Merged
codeboten merged 19 commits intoopen-telemetry:masterfrom Aug 14, 2020
Merged
Conversation
lzchen
approved these changes
Aug 5, 2020
50e7b08 to
96dbdb9
Compare
This reverts commit de34172.
This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span. WIP: there is one failing test case, apparently the context does not get cleared before running every test case. This seems related to the order in which test cases are being run.
This reverts commit de34172.
This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span. WIP: there is one failing test case, apparently the context does not get cleared before running every test case. This seems related to the order in which test cases are being run.
This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span. WIP: there is one failing test case, apparently the context does not get cleared before running every test case. This seems related to the order in which test cases are being run.
This reverts commit a916d51.
toumorokoshi
approved these changes
Aug 14, 2020
Member
toumorokoshi
left a comment
There was a problem hiding this comment.
LGTM! one typo to look at.
...trumentation-opentracing-shim/src/opentelemetry/instrumentation/opentracing_shim/__init__.py
Outdated
Show resolved
Hide resolved
…/src/opentelemetry/instrumentation/opentracing_shim/__init__.py Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
Contributor
Author
Fixed |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…lemetry/context-base (open-telemetry#925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305