The committers listed above are authorized under a signed CLA.

• ✅ login: wasup-yash / name: Yash sharma (750180c, 621d8b2, 995d5fc, badcb13, 95de5e9)
• ✅ login: lzchen / name: Leighton Chen (6bd95f8, dfa6e90, 5b42a7e)

@lzchen tagging for the review if good then can proceed to merge

Thanks. Care to add a changelog entry and update an existing test or add a new one?

did the entry part, but couldn't find the test specifically for the encoding part, can you point me to exactly where are we testing for the encoding formats?

@wasup-yash

Please mark this as PR if it is ready to review.

@wasup-yash

Please mark this as PR if it is ready to review.

done

@wasup-yash

You can either add a new file here creating a test suite to just test encode_value or you can add to the existing encode_attributes test suit to include these uses cases.

what could be the reason tests are failing, is it cause the tests are not written correctly? (I am not familiar with the tests written in Python so If anyone can suggest what needs to be done here )

@wasup-yash

Left a comment on how to fix your test.

Also, please add a CHANGELOG entry.

@wasup-yash Need to run black over your changes and add a CHANGELOG entry, I suggest to setup pre-commit as in CONTRIBUTING.md to have it done automatically at commit time.

Need to run black over your changes

what does it mean though , understood the pre-commit part though

Do I have to run pre-commit run --all-files and then commit the changes as there were a lot of changes ? cause this time I did just only , a pre-commit install and then committed the changelog.md and there were 3 skipped files by pre-commit that was it :)