Remove workaround trace-context failures.#364
Merged
c24t merged 1 commit intoopen-telemetry:masterfrom Jan 13, 2020
Merged
Conversation
Signed-off-by: dgzlopes <danielgonzalezlopes@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 38 38
Lines 1839 1839
Branches 217 217
=======================================
Hits 1560 1560
Misses 214 214
Partials 65 65Continue to review full report at Codecov.
|
Oberon00
approved these changes
Jan 13, 2020
Member
Oberon00
left a comment
There was a problem hiding this comment.
LGTM, since the CI is still successfully building.
hectorhdzg
approved these changes
Jan 13, 2020
c24t
approved these changes
Jan 13, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
closes open-telemetry#364 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #329.
As @condorcet pointed out, the Multidict bug affecting #329 has been fixed. This PR removes the workaround added on #330 as it's no longer needed.
Signed-off-by: dgzlopes danielgonzalezlopes@gmail.com