Skip to content

Verify previous point is returned for cumulative instruments#2773

Merged
ocelotl merged 7 commits intoopen-telemetry:mainfrom
ocelotl:issue_2755
Jun 30, 2022
Merged

Verify previous point is returned for cumulative instruments#2773
ocelotl merged 7 commits intoopen-telemetry:mainfrom
ocelotl:issue_2755

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Jun 21, 2022

Fixes #2755

@ocelotl ocelotl requested a review from a team June 21, 2022 08:14
@ocelotl ocelotl self-assigned this Jun 21, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 21, 2022
@ocelotl ocelotl requested a review from lzchen June 24, 2022 15:46
@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Jun 24, 2022

@srikanthccv and @aabmass could probably provide a better review.

srikanthccv
srikanthccv reviewed Jun 24, 2022
View reviewed changes
Comment thread exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py Outdated
@ocelotl ocelotl requested a review from srikanthccv June 27, 2022 11:50
@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented Jun 28, 2022

I may have forgotten what's happening here https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py#L139-L144. I would like another approval on this before merging.

@srikanthccv srikanthccv requested a review from aabmass June 28, 2022 18:52
aabmass
aabmass reviewed Jun 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@aabmass aabmass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR just to verify the behavior of Prometheus? I was thinking we should test this for the SDK's behavior, e.g. with InMemoryMetricReader and cumulative config.

Basically what Srikanth said, I'd like to know if the internals of SDK are working not just prom

Comment thread exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py Outdated
Comment thread exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py Outdated
@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Jun 30, 2022

Is this PR just to verify the behavior of Prometheus? I was thinking we should test this for the SDK's behavior, e.g. with InMemoryMetricReader and cumulative config.

Basically what Srikanth said, I'd like to know if the internals of SDK are working not just prom

Fair point, I added another test that uses InMemoryMetricReader.

aabmass
aabmass reviewed Jun 30, 2022
View reviewed changes
Comment thread opentelemetry-sdk/tests/metrics/test_in_memory_metric_reader.py
@ocelotl ocelotl requested a review from aabmass June 30, 2022 17:07
@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Jun 30, 2022

@aabmass removed the parameters, PTAL 👍

@ocelotl ocelotl mentioned this pull request Jun 30, 2022
Closed
aabmass
aabmass approved these changes Jun 30, 2022
View reviewed changes
Comment thread exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
@lzchen lzchen mentioned this pull request Jun 30, 2022
Merged
@ocelotl ocelotl merged commit f7a3e62 into open-telemetry:main Jun 30, 2022
@ocelotl ocelotl deleted the issue_2755 branch June 30, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

+1 more reviewer

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocelotl ocelotl

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Verify prev point is returned for cumulative readers instead of None

4 participants

@ocelotl @lzchen @srikanthccv @aabmass