Use buf to detect for wire breaking changes#415
Merged
arminru merged 3 commits intoopen-telemetry:mainfrom Aug 3, 2022
Merged
Conversation
Member
tigrannajaryan
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is very useful.
arminru
approved these changes
Aug 2, 2022
| git remote set-branches origin '*' | ||
| git fetch --depth=1 origin main | ||
| git branch main origin/main | ||
| - name: Run make breaking-change with json output to annotate PR |
Member
There was a problem hiding this comment.
I agree that this is very helpful, thank you!
It would be nice if you could add a breaking change in a new (dummy) PR based off this branch to illustrate how this would work.
Member
Author
There was a problem hiding this comment.
tigrannajaryan
approved these changes
Aug 2, 2022
arminru
approved these changes
Aug 3, 2022
bogdandrutu
added a commit
that referenced
this pull request
Aug 3, 2022
…#419) * Use buf to detect for wire breaking changes (#415) * Make it possible to indicate partial success in an OTLP export response [2] (#414) * Make it possible to indicate partial success in an OTLP export response * Update changelog with PR number * PR suggestions * Improve docs around using rejected as 0 to convey warnings * Adapt comments to match recent spec wording changes * Clarify behavior of partial success not set/empty Co-authored-by: Aaron Abbott <aaronabbott@google.com> Co-authored-by: Joao Grassi <joao@joaograssi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Buf breaking to check PRs for wire and json breaking changes. Here is an example PR showing this in action. There was some interest for this in #400 (comment).
The config can be tweaked to add/remove specific rules if this is too noisy, see https://docs.buf.build/breaking/configuration.