Merged
Conversation
The event logger was a Development-status component of the logging signal. It has been removed in favour of adding emitEvent to the logger interface, see open-telemetry/opentelemetry-specification#4319
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
============================================
+ Coverage 73.27% 73.45% +0.18%
Complexity 2683 2683
============================================
Files 387 387
Lines 8014 8014
============================================
+ Hits 5872 5887 +15
+ Misses 2142 2127 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisLightfootWild
approved these changes
Jan 6, 2025
| } | ||
|
|
||
| /** | ||
| * @phan-suppress PhanDeprecatedClass,PhanDeprecatedFunction |
Contributor
There was a problem hiding this comment.
Could this work if moved to phan-suppress-next-line around the event logger? 🤔
agoallikmaa
approved these changes
Jan 8, 2025
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Jan 9, 2025
The event logger was a Development-status component of the logging signal. It has been removed in favour of adding emitEvent to the logger interface, see open-telemetry/opentelemetry-specification#4319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event logger was a Development-status component of the logging signal. It has been removed in favour of adding emitEvent to the logger interface, see open-telemetry/opentelemetry-specification#4319
Related: #1459