Convert hibernate-4.0 groovy tests - part 1#9211
Merged
mateuszrzeszutek merged 4 commits intoAug 17, 2023
Merged
Conversation
…ng back in session id assertions, additional assertion around mapping exception
mateuszrzeszutek
approved these changes
Aug 17, 2023
Comment on lines
+430
to
+440
| .hasEventsSatisfyingExactly( | ||
| event -> | ||
| event | ||
| .hasName(EXCEPTION_EVENT_NAME) | ||
| .hasAttributesSatisfyingExactly( | ||
| equalTo( | ||
| EXCEPTION_TYPE, mappingException.getClass().getName()), | ||
| equalTo(EXCEPTION_MESSAGE, mappingException.getMessage()), | ||
| satisfies( | ||
| EXCEPTION_STACKTRACE, | ||
| val -> val.isInstanceOf(String.class)))), |
Member
There was a problem hiding this comment.
Nit: could be just
Suggested change
| .hasEventsSatisfyingExactly( | |
| event -> | |
| event | |
| .hasName(EXCEPTION_EVENT_NAME) | |
| .hasAttributesSatisfyingExactly( | |
| equalTo( | |
| EXCEPTION_TYPE, mappingException.getClass().getName()), | |
| equalTo(EXCEPTION_MESSAGE, mappingException.getMessage()), | |
| satisfies( | |
| EXCEPTION_STACKTRACE, | |
| val -> val.isInstanceOf(String.class)))), | |
| .hasException(mappingException), |
This was referenced Aug 18, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7195
Theres a lot of code in the hibernate 4-0 test suite, so I am breaking up #9191 into smaller pieces. This is the first piece.
Valueand updates references to the new locationSessionTest.test hibernate actionthey combined code forStatelessSessionandSession, but I ended up splitting these out into separate tests (testHibernateAction, testHibernateActionStateless).Thanks for taking the time to review.