Convert hibernate-4.0 tests from groovy to java#9191
Closed
jaydeluca wants to merge 16 commits into
Closed
Conversation
…va-instrumentation into hibernate-4-0
…mentation into hibernate-4-0
16da412 to
290a356
Compare
Contributor
|
Hey @jaydeluca , thanks for doing this work....and I kinda hate to ask, but it's a pretty large changeset. Is there any chance you could do like one or two test classes at a time across several successive PRs? I think it would make reviewing easier and we can move it through quicker that way. |
Member
Author
|
@breedx-splk I would be happy to |
Contributor
Awesome thank you so much! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7195
Notes:
EntityManagerTestI split out the first test to have the "persist" test case run on it's own to reduce some of the conditionals in the combined testorg.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory' defined in class spring.jpa.PersistenceConfig: Invocation of init method failed; nested exception is java.lang.RuntimeException: error trying to scan <jar-file>:EntityManagerTestand theSpringJpaTestthere was some logic in the old tests that allowed some conditional span name checks in the groovy versions that made things a little tricky. I added some logic (here and here) to account for them, hopefully it's still clear what is going on but if it's not let me know and I can try and come up with another way.