Fix npe with pulsar and ssl#9166
Merged
Merged
Conversation
mateuszrzeszutek
approved these changes
Aug 9, 2023
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8939
As far as I understand this NPE happens because
NettySslInstrumentationHandler.channelRegistered()is never called. In our testSslHandleris set up in theChannelInitializer.initChannel. Pulsar does it from a background thread, by the timeSslHandleris added the channel is already registered.