Remove final from local variables#732
Conversation
|
@heyams Thanks a lot for helping with this! Can you describe your approach? IntelliJ has an automated fix for unnecessary final Help -> Find Action -> Run Inspection By Name -> Unnecessary final on local variable or parameter You can use Fix All to have it automatically fix. Then just 821e18a makes me nervous that you may be doing this manually, meaning there's chance of manual error. |
|
@anuraaga Oops, I wasn't aware there was an automatic way to fix this. I did it manually 😢 |
|
@anuraaga I can create a separate PR using your suggestion to see if it will fix all the local variables except those accessed by the inner classes. |
|
I don't think you need to create a separate PR - how about running that on this PR. It may catch anything you missed, or otherwise it means you got them all :) |
|
@anuraaga Cool, will do. Thanks! |
|
@anuraaga I missed 10 files. Find Action works. Thanks! |
Oh nice! I didn't know about this either. I need to hang around @anuraaga more 😄 |
anuraaga
left a comment
There was a problem hiding this comment.
Thanks a lot! As this is purely cosmetic and has a huge chance of merge conflicts I'm going to go ahead and merge this. I scrolled through really fast and "confirm"ed that the left-hand side has a lot of red finals being removed.
Take a look at videos by Trisha Gee, such as this https://www.youtube.com/watch?v=9AMcN-wkspU :) |
|
@heyams Official Gitter channel will do :) https://gitter.im/open-telemetry/opentelemetry-java-instrumentation |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Fix #592.