Migrate Guava tests to Java#5668
Merged
Merged
Conversation
mateuszrzeszutek
approved these changes
Mar 23, 2022
laurit
reviewed
Mar 23, 2022
…metry/javaagent/instrumentation/guava/ListenableFutureTest.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
trask
approved these changes
Mar 23, 2022
…java-instrumentation into guava-tests-java
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Migrate Guava tests to Java * Update instrumentation/guava-10.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/guava/ListenableFutureTest.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com> * Workaround inline mock issue Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes AbstractPromiseTest since guava was the only implementation. If we find a reason to abstract out tests for futures later, we can restore something like it then