Migrate gRPC tests to Java#5521
Merged
Merged
Conversation
231f601 to
8f43553
Compare
trask
approved these changes
Mar 9, 2022
Comment on lines
+59
to
+60
| @CartesianTest.Values(ints = {1, 2, 3}) int clientMessageCount, | ||
| @CartesianTest.Values(ints = {1, 2, 3}) int serverMessageCount) |
| event -> | ||
| event | ||
| .hasName("message") | ||
| .hasAttributesSatisfying( |
Member
There was a problem hiding this comment.
do we have hasAttributesSatisfyingExactly on event yet?
Contributor
Author
There was a problem hiding this comment.
Not yet unfortunately noticed the gap with this PR
| span.hasName("example.Greeter/Conversation") | ||
| .hasKind(SpanKind.SERVER) | ||
| .hasParent(trace.getSpan(0)) | ||
| .hasAttributesSatisfyingExactly( |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Migrate gRPC tests to Java * check * clean
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.