Migrate google-http-client tests to Java.#5399
Merged
Merged
Conversation
Contributor
Author
|
My remote IDE went crazy on this one 🙀 |
trask
approved these changes
Feb 19, 2022
trask
left a comment
Member
There was a problem hiding this comment.
My remote IDE went crazy on this one 🙀
looks like it did something weird to AbstractGrpcTest.groovy
e660362 to
70adc19
Compare
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it'll be good and relatively straightforward to provide library instrumentation for google-http-client. First step of course is to migrate the tests from Groovy.