Fix triggering of reverse name lookup#5297
Merged
Merged
Conversation
iNikem
approved these changes
Feb 3, 2022
mateuszrzeszutek
approved these changes
Feb 3, 2022
laurit
approved these changes
Feb 3, 2022
laurit
left a comment
Contributor
There was a problem hiding this comment.
RabbitChannelNetAttributesGetter, RabbitReceiveNetAttributesGetter and ReactorNettyHttpClientAttributesGetter might have the same issue.
| if (address.getAddress() != null) { | ||
| return address.getAddress().getHostName(); | ||
| } | ||
| return address.getHostString(); |
Contributor
There was a problem hiding this comment.
I believe getHostString may return ip address. I hope spec is ok with this, if it isn't I guess we could compare it with getHostAddress and return null in case they match.
Member
There was a problem hiding this comment.
necrolyte2
approved these changes
Feb 3, 2022
Member
Author
thx! I'll fix those in a follow-up, since PR builds for those should be faster than PR builds on this one which touches core classes |
This was referenced Feb 17, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Fix triggering of DNS lookup * Update test * Update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5295