Normalize sql statements to elide literal numbers and strings.#366
Conversation
trask
left a comment
There was a problem hiding this comment.
This all looks really good to me 👍
I think it would be nice for the normalization to happen off the main thread (in a span processor pipeline, prior to sending to exporter), but we can revisit that later (need to address #368 first 😄).
It's pretty darn fast (sub-sub-millisecond for normal sql), and could be made faster if need be. But I agree, we're going to encounter things like this that necessitate some off-thread processing. |
|
Can any gradle/circleci expert on here help with the spotless license check here? The issue is that javacc generates some files in build/generated/, and the |
|
I can confirm. Works locally. Fails on CI. Really not sure what's the difference. Looked a bit at the spotless gradle plugin source code even 😭. Some ideas worth trying (in this order of invasiveness I think):
I think the last one should work, it's not ideal as it bypasses spotless' built-in detection of Java source sets, but if the other ideas don't work, then I'm all in on the last one 👍. |
…eci build work.
I confirmed that this properly failed the build if I remove a license header from a src/ directory.
|
|
Yes. I don't know if you saw the commit comment, but I did manually make sure that a missing license header in src/* does in fact still fail the build. |
…telemetry#366) * Normalize sql statements to elide literal numbers and strings. * Missed one SlickTest sql normalization. * Fix muzzle order for helper classes. * Change name of feature flag * Upgrade to latest spotless version in an attempt #1 to make the circleci build work. * Attempt 2 to make circleci build happy - exclude build/generated/** from spotless. * Attempt 3 to get circleci build working, adding *.java to the exclude line. * Change exclude of generated files to include of just the src/ directory. I confirmed that this properly failed the build if I remove a license header from a src/ directory.
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
Normalize sql statements using a javacc-based lexer.