Add v3 preview config fallback#18936
Merged
Merged
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates semconv stability initialization to resolve the common.v3_preview flag from declarative config first, then fall back to the legacy otel.semconv-stability.v3-preview system property/env-var path to keep behavior consistent with existing semconv stability flags.
Changes:
- Replaces direct
common.v3_previewboolean-with-default lookup with a resolver that can detect “unset”. - Adds
resolveV3Preview(...)to fall back toConfigPropertiesUtil.getBoolean("otel.semconv-stability.v3-preview", false)when declarative config provides no value.
laurit
approved these changes
Jun 9, 2026
zeitlinger
added a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 9, 2026
Layered on top of open-telemetry#18936: - New schema: <domain>.semconv.version (0/1) + dual_emit - New top-level stability_opt_in_list config - Precedence: domain schema > stability list > existing legacy fallback Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
common.v3_previewfall back tootel.semconv-stability.v3-previewviaConfigPropertiesUtilwhen declarative config does not provide a value. This keeps v3 preview resolution consistent with the existing semconv stabilityopt_inandpreviewflags, which read declarative config first and fall back to system properties/environment variables.Motivated by https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/18934/changes#r3373093942