@trask please check again

hmm, changing the LoggingCustomizer interface breaks our distribution. Not a biggie, I can fix it but isn't this sort of API change a breaking change?

javaagent-tooling is an artifact of internal stuff only for distros (as opposed to javaagent-extension-api which is for more public consumption), but we can flag these in the release notes going forward if that helps.

Making the EarlyInitAgentConfig.getString (and other get*) private is annoying since the property we're looking at (elastic.otel.javaagent.log.level) is not one listed there. ie this is not distribution friendly.

It's not terrible, I can look for the setting directly, but (and @zeitlinger ) I think for ongoing changes to these to make it ConfigProvider friendly, please check how distributions can use additional options

Making the EarlyInitAgentConfig.getString (and other get*) private is annoying since the property we're looking at (elastic.otel.javaagent.log.level) is not one listed there. ie this is not distribution friendly.

It's not terrible, I can look for the setting directly, but (and @zeitlinger ) I think for ongoing changes to these to make it ConfigProvider friendly, please check how distributions can use additional options

Going forward, the ConfigProvider API is meant to be used whenever possible - much like we're already doing it in the agent.

A trimmed down version of https://github.com/zeitlinger/opentelemetry-java-instrumentation/blob/79edac70672b2d52bfa35b8b5727b6370e566261/declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/ConfigPropertiesBackedConfigProvider.java#L18 sholud be added to contrib. If you want, you can do that right now 😄

Does that help with config before the agent is initialized (which is what EarlyInitAgentConfig is needed for)?

Does that help with config before the agent is initialized (which is what EarlyInitAgentConfig is needed for)?

no it doesn't - maybe you'll have to have your own copy of ConfigPropertiesUtil (which is also going to javaagent-bootstrap in #15809)