Skip to content

Ensure consistent EarlyInitAgentConfig access#15761

Closed
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:early-agent-config
Closed

Ensure consistent EarlyInitAgentConfig access#15761
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:early-agent-config

Conversation

@trask

@trask trask commented Jan 2, 2026

Copy link
Copy Markdown
Member

Limit it to specific known properties.

Future PRs:

  • See if a couple of the properties can be moved out of "early config" and to normal config
  • Stop passing around EarlyInitAgentConfig instance now that it's a singleton

/**
* @deprecated Use {@link #get()} instead.
*/
@Deprecated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just remove? This is not a library

AutoConfiguredOpenTelemetrySdk autoConfiguredSdk =
OpenTelemetryInstaller.installOpenTelemetrySdk(
this.getClass().getClassLoader(), EarlyInitAgentConfig.create());
this.getClass().getClassLoader(), EarlyInitAgentConfig.get());

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pass it around at all?

@trask

trask commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

Closing, need to think more about early agent config

@zeitlinger

Copy link
Copy Markdown
Member

created #15787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants