Actually use requested number of versions to test muzzle#1396
Merged
Conversation
trask
approved these changes
Oct 16, 2020
Comment on lines
+273
to
+278
| if (predicate.test(range.lowestVersion)) { | ||
| result.add(range.lowestVersion.toString()) | ||
| } | ||
| if (predicate.test(range.highestVersion)) { | ||
| result.add(range.highestVersion.toString()) | ||
| } |
Member
There was a problem hiding this comment.
I think maybe good not to apply predicate test to highestVersion, so we can find out early that we may issue with future version.
Though then we tend to just limit the max version, and we never get notified when a non-"beta" version is released, which is worse.
So ignore me, all good 😄.
anuraaga
approved these changes
Oct 16, 2020
mateuszrzeszutek
approved these changes
Oct 16, 2020
schmikei
pushed a commit
to schmikei/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 17, 2025
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1389