make elasticsearch-* indy compatible#11554
Merged
Merged
Conversation
SylvainJuge
added a commit
to SylvainJuge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 11, 2024
trask
approved these changes
Jun 11, 2024
Member
|
closing and re-opening to try to fix CI |
Member
|
@SylvainJuge if you rebase your PRs, CI should be healthy again |
b045d9a to
c60f94e
Compare
Contributor
Author
|
@trask can you add |
laurit
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using a common classloader for all "elasticsearch" instrumentation.
Part of #11457
"indy compatible" is defined in https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/11546/files#diff-c01c02c7d6cde11986ed4c95f749da6318b0deb89c371d866319371cc1757bd0
This PR needs to have the
indy testlabel added for validation in CI.Local validation can be done with
gradle test -PtestIndy=true