Fix InstrumentedRecordInterceptor closing the trace too early#11471
Merged
trask merged 2 commits intoJun 13, 2024
Conversation
…ll decorated RecordInterceptor before closing the trace.
c99d9f4 to
9b15525
Compare
Contributor
|
@Questlog could you sign the CLA, we can not accept the PR without that. |
…mentedRecordInterceptor. Close trace in case of exceptions.
Contributor
Author
|
To sign the CLA, I have to get in contact with my companys CLA Manager to sort this out. |
laurit
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spring Kafka InstrumentedRecordInterceptor was closing the trace before calling the decorated RecordInterceptor.
We print logs and do some other tasks inside the Kafka RecordInterceptor, especially if a failure occured after consuming an event.
This caused our logs not to be part of the trace when the kafka event got finished successfully or with failures.