Add workflow step that shows build scan url#11088
Merged
Merged
Conversation
trask
approved these changes
Apr 10, 2024
Comment on lines
+272
to
+276
| if: ${{ hashFiles('build-scan.txt') != '' }} | ||
| run: echo "build-scan=$(cat build-scan.txt)" >> $GITHUB_OUTPUT | ||
| - name: Build scan | ||
| if: ${{ hashFiles('build-scan.txt') != '' }} | ||
| run: echo ${{ steps.read-build-scan.outputs.build-scan }} |
Contributor
Author
There was a problem hiding this comment.
The sample code I found from google used 2 steps. I was intending on relying on you pointing out a simpler solution if one exists.
Member
There was a problem hiding this comment.
maybe the $GITHUB_OUTPUT is displayed in some summary box?
jeanbisutti
approved these changes
Apr 11, 2024
trask
reviewed
Apr 11, 2024
trask
reviewed
Apr 11, 2024
trask
reviewed
Apr 11, 2024
trask
reviewed
Apr 11, 2024
Member
|
Thanks for adding this @laurit! |
laurit
added a commit
to laurit/opentelemetry-java-instrumentation
that referenced
this pull request
May 24, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.