Update the OpenTelemetry SDK version to 1.37.0#11066
Merged
Merged
Conversation
This was referenced Apr 9, 2024
laurit
reviewed
Apr 9, 2024
| dependencies { | ||
| implementation(project(":instrumentation-api")) | ||
| implementation("io.opentelemetry:opentelemetry-extension-incubator") | ||
| implementation("io.opentelemetry:opentelemetry-api-incubator") |
Contributor
There was a problem hiding this comment.
is this dependency needed at all?
Contributor
There was a problem hiding this comment.
this module does not use EventLogger as far as I can tell
Member
Author
There was a problem hiding this comment.
right, mixed that up with another module - removed
laurit
reviewed
Apr 9, 2024
Comment on lines
+103
to
+116
| @Override | ||
| @CanIgnoreReturnValue | ||
| public Span addLink(SpanContext spanContext) { | ||
| agentSpan.addLink(Bridging.toAgent(spanContext)); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| @CanIgnoreReturnValue | ||
| public Span addLink(SpanContext spanContext, Attributes attributes) { | ||
| agentSpan.addLink(Bridging.toAgent(spanContext), Bridging.toAgent(attributes)); | ||
| return this; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
this deviates a bit from our usual approach of adding bridging for new methods in a subclass, but here it is much easier to do it the way it is so I think it is fine.
laurit
approved these changes
Apr 9, 2024
trask
reviewed
Apr 9, 2024
Comment on lines
18
to
21
| configurations.configureEach { | ||
| if (name == "testRuntimeClasspath" || name == "testCompileClasspath") { | ||
| resolutionStrategy { | ||
| force("io.opentelemetry:opentelemetry-api:1.31.0") |
Member
There was a problem hiding this comment.
@laurit should we add something similar in all of the opentelemetry-api-* javaagent modules?
trask
reviewed
Apr 9, 2024
Comment on lines
+18
to
+26
| testing { | ||
| suites { | ||
| val incubatorTest by registering(JvmTestSuite::class) { | ||
| dependencies { | ||
| implementation("io.opentelemetry:opentelemetry-api-incubator:1.37.0-alpha") | ||
| } | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
it might be worth adding an oldAndNewIncubatorTest that pulls in both the -extension-incubator and -api-incubator artifacts
laurit
added a commit
to laurit/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 12, 2024
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.