Merged
Conversation
trask
approved these changes
Aug 21, 2020
Member
trask
left a comment
There was a problem hiding this comment.
just fyi, several repos have or are in process of moving to GitHub Actions: open-telemetry/community#398
Contributor
Author
Good to know, and I'll be sure to investigate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
These changes add an initial CircleCI config and additional make assemble and test targets for its use.
Testing:
local cli and branch job run.
Documentation:
Added build status shield
Outstanding items:
This is a basic config and only includes openjdk 8 usage. We'll likely want to add more targets as functionality lands to ensure wide compatibility.
Also doesn't adopt workflows or additional executors that will be needed when we have actual testing and publishing requirements.