JMX Scraper - YAML config and integration test for Hadoop#3
Merged
robsunday merged 12 commits intorobsunday:integration-test-hadoopfrom Dec 19, 2024
Merged
Conversation
added 9 commits
October 28, 2024 14:24
robsunday
requested changes
Nov 27, 2024
...ationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/HadoopIntegrationTest.java
Outdated
Show resolved
Hide resolved
| "/hadoop/etc/hadoop/hadoop-env.sh") | ||
| .waitingFor(Wait.forListeningPort().withStartupTimeout(Duration.ofMinutes(200))) | ||
| .withExposedPorts(jmxPort) | ||
| .withCreateContainerCmdModifier(cmd -> cmd.withHostName("test-host")) |
Owner
There was a problem hiding this comment.
I do not remember if it helped in anything. If test runs without this line then please remove it.
| .waitingFor(Wait.forListeningPort().withStartupTimeout(Duration.ofMinutes(200))) | ||
| .withExposedPorts(jmxPort) | ||
| .withCreateContainerCmdModifier(cmd -> cmd.withHostName("test-host")) | ||
| .waitingFor(Wait.forListeningPort()); |
Owner
There was a problem hiding this comment.
In other integration tests we started also exposing and waiting for some service point of target application. It makes the tests more stable. Please identify some port that is opened by Hadoop (other than JMX ports), and ezpose it and wait for it, like for example in ActiveMQ or Cassandra.
added 2 commits
December 3, 2024 15:04
robsunday
reviewed
Dec 11, 2024
robsunday
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created
hadoop.yamlfor connecting JMX Insight to Hadoop based on jmx-metrics groovy script. Updated jmx-metrics units to match semconv rules.