Remove nullable from file config Factory contract#6612
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Aug 8, 2024
Merged
Remove nullable from file config Factory contract#6612jack-berg merged 3 commits intoopen-telemetry:mainfrom
jack-berg merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6612 +/- ##
============================================
- Coverage 90.19% 90.18% -0.02%
+ Complexity 6281 6260 -21
============================================
Files 697 697
Lines 18903 18871 -32
Branches 1852 1843 -9
============================================
- Hits 17050 17019 -31
Misses 1281 1281
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. |
…y-java into file-config-nullable
jaydeluca
approved these changes
Aug 7, 2024
breedx-splk
pushed a commit
to breedx-splk/opentelemetry-java
that referenced
this pull request
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I reached a misguided conclusion that the file config Factory interface needed its model argument to be nullable. This PR fixes that, simplifying the implementation quite a bit in the process.
Originally discussed here: #6493 (comment)