Update Instrumentation to metrics v0.28.0 by MadVikingGod · Pull Request #1977 · open-telemetry/opentelemetry-go-contrib

MadVikingGod · 2022-03-24T15:18:44Z

The following Instrumentation packages use the metrics API, and are updated to v0.28.0

instrumentation/github.com/astaxie/beego/otelbeego
instrumentation/github.com/astaxie/beego/otelbeego/test
instrumentation/github.com/gocql/gocql/otelgocql
instrumentation/github.com/gocql/gocql/otelgocql/test
instrumentation/host
instrumentation/net/http/otelhttp
instrumentation/net/http/otelhttp/test
instrumentation/runtime

Note:
In v0.27.0 of the metrics API there was otel/metric/metrictest. This had a MeterProvider that did not use the SDK to record metrics in memory. That was removed from v0.28.0 and will be replaced in open-telemetry/opentelemetry-go#2722

codecov · 2022-03-24T17:11:08Z

Codecov Report

Merging #1977 (cd160a1) into main (9d5673a) will increase coverage by 0.1%.
The diff coverage is 36.8%.

@@           Coverage Diff           @@
##            main   #1977     +/-   ##
=======================================
+ Coverage   72.1%   72.3%   +0.1%     
=======================================
  Files        124     126      +2     
  Lines       5330    5412     +82     
=======================================
+ Hits        3848    3916     +68     
- Misses      1370    1379      +9     
- Partials     112     117      +5

Impacted Files	Coverage Δ
instrumentation/host/host.go	`0.0% <0.0%> (-74.8%)`	⬇️
instrumentation/runtime/runtime.go	`53.8% <64.1%> (-20.0%)`	⬇️
...ation/github.com/astaxie/beego/otelbeego/config.go	`100.0% <100.0%> (ø)`
...ntation/github.com/gocql/gocql/otelgocql/config.go	`57.1% <100.0%> (+57.1%)`	⬆️
...ion/github.com/gocql/gocql/otelgocql/instrument.go	`62.5% <100.0%> (+62.5%)`	⬆️
instrumentation/net/http/otelhttp/config.go	`80.6% <100.0%> (ø)`
instrumentation/net/http/otelhttp/handler.go	`78.2% <100.0%> (ø)`
instrumentation/host/version.go	`0.0% <0.0%> (-100.0%)`	⬇️
... and 7 more

Aneurysm9 · 2022-03-24T20:44:56Z

+		return err
+	}
+
+	err = r.meter.RegisterCallback(


Should this be three separate callbacks as it was before? I'm not sure what impact combining them has.

I don't believe that any of the callbacks are run in separate routines. So this would just dispense with the overhead of tracking 3 different closures and calling each one serially.

MadVikingGod · 2022-03-24T21:56:46Z

+		return err
+	}
+
+	err = r.meter.RegisterCallback(


I don't believe that any of the callbacks are run in separate routines. So this would just dispense with the overhead of tracking 3 different closures and calling each one serially.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: David Ashpole <dashpole@google.com>

MadVikingGod · 2022-03-25T00:45:51Z

In an effort to enable users to test the new release I will merge this sooner than the 24h window. This already has approvals from the maintainers and 1+ approver.

…x` is "unstable", and as it specifieds a minimum version, that will include "any breaking change after". try to fix go.opentelemetry.io dependency hell docker ("indirect") and buildkit ("direct") specify `v0.29.0`; ```bash go mod graph --modfile=vendor.mod | grep ' go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp' github.com/docker/docker go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.29.0 github.com/moby/buildkit@v0.11.4 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.29.0 ``` containerd specified v0.34.0 for `go.opentelemetry.io/otel/metric`; ```bash go mod graph --modfile=vendor.mod | grep ' go.opentelemetry.io/otel/metric@' github.com/docker/docker go.opentelemetry.io/otel/metric@v0.34.0 github.com/containerd/containerd@v1.7.0-rc.2 go.opentelemetry.io/otel/metric@v0.34.0 github.com/moby/buildkit@v0.11.4 go.opentelemetry.io/otel/metric@v0.27.0 go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@v0.37.0 go.opentelemetry.io/otel/metric@v0.34.0 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.29.0 go.opentelemetry.io/otel/metric@v0.27.0 go.opentelemetry.io/otel/internal/metric@v0.27.0 go.opentelemetry.io/otel/metric@v0.27.0 ``` But BuildKit uses; ```bash git checkout v0.11.4 go mod graph | grep ' go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp' github.com/moby/buildkit go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.29.0 k8s.io/apiserver@v0.22.5 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.20.0 k8s.io/component-base@v0.22.5 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.20.0 ``` But looks like BuildKit has older versions of the other packages installed; ```bash go mod graph | grep ' go.opentelemetry.io/otel/metric@' github.com/moby/buildkit go.opentelemetry.io/otel/metric@v0.27.0 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.29.0 go.opentelemetry.io/otel/metric@v0.27.0 go.opentelemetry.io/otel/internal/metric@v0.27.0 go.opentelemetry.io/otel/metric@v0.27.0 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 go.opentelemetry.io/otel@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 go.opentelemetry.io/otel/exporters/otlp@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 go.opentelemetry.io/otel/oteltest@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 go.opentelemetry.io/otel/sdk/export/metric@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 go.opentelemetry.io/otel/sdk/metric@v0.20.0 go.opentelemetry.io/otel/metric@v0.20.0 ``` Looks like `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.31.0` is the first version taking the new metrics into account; https://github.com/open-telemetry/opentelemetry-go-contrib/blob/instrumentation/net/http/otelhttp/v0.31.0/instrumentation/net/http/otelhttp/handler.go#L52-L53 Changed in open-telemetry/opentelemetry-go-contrib@a587520 (open-telemetry/opentelemetry-go-contrib#1977) Unfortunately, updating these to v0.31.0 works around the other issues, but breaks BuildKit, which doesn't support the newer API; go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace v0.31.0 // indirect // updated to v0.31+ to account for moby#44530 (comment) go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.31.0 // indirect // updated v0.31+ to account for moby#44530 (comment) ```bash Building static bundles/binary-daemon/dockerd (linux/arm64)... vendor/github.com/moby/buildkit/util/tracing/transform/span.go:34:26: sd.InstrumentationLibrarySpans undefined (type *"github.com/docker/docker/vendor/go.opentelemetry.io/proto/otlp/trace/v1".ResourceSpans has no field or method InstrumentationLibrarySpans) vendor/github.com/moby/buildkit/util/tracing/transform/span.go:56:17: undefined: v11.InstrumentationLibrary vendor/github.com/moby/buildkit/util/tracing/transform/instrumentation.go:9:42: undefined: commonpb.InstrumentationLibrary vendor/github.com/moby/buildkit/worker/containerd/containerd.go:56:74: cannot use &gogoptypes.Empty{} (value of type *"github.com/docker/docker/vendor/github.com/gogo/protobuf/types".Empty) as *emptypb.Empty value in argument to client.IntrospectionService().Server ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

MadVikingGod and others added 5 commits March 24, 2022 14:38

net/http

8a3e709

beego

3ad978b

gocql

5eae6e3

host

04ecdb1

runtime

67a75ae

Aneurysm9 mentioned this pull request Mar 24, 2022

net/http: add requests count metric with status code label #771

Closed

MadVikingGod added 3 commits March 24, 2022 16:20

Upgrade examples to new version of trace api/sdk

51873c9

fix linting errors

f0a8a7d

Changelog

75bf090

MadVikingGod marked this pull request as ready for review March 24, 2022 16:41

MadVikingGod requested review from Aneurysm9, MrAlias, XSAM, dashpole, evantorrie, hanyuancheung, jmacd, paivagustavo and pellared as code owners March 24, 2022 16:41

MadVikingGod mentioned this pull request Mar 24, 2022

Upgrade otel dependencies to v1.6.0/v0.28.0 #1978

Merged

MadVikingGod changed the title ~~[WIP] Update Instrumentation to metrics v0.28.0~~ Update Instrumentation to metrics v0.28.0 Mar 24, 2022

MrAlias approved these changes Mar 24, 2022

View reviewed changes

Comment thread CHANGELOG.md Outdated

Aneurysm9 approved these changes Mar 24, 2022

View reviewed changes

dashpole reviewed Mar 24, 2022

View reviewed changes

Comment thread instrumentation/github.com/gocql/gocql/otelgocql/test/gocql_test.go

dashpole approved these changes Mar 24, 2022

View reviewed changes

MadVikingGod commented Mar 24, 2022

View reviewed changes

MadVikingGod and others added 2 commits March 24, 2022 16:59

Apply suggestions from code review

10c774c

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: David Ashpole <dashpole@google.com>

Apply suggestions from code review

cd160a1

MadVikingGod merged commit a587520 into open-telemetry:main Mar 25, 2022

MadVikingGod deleted the mvg/update-metric-api branch March 25, 2022 00:46

MrAlias mentioned this pull request Mar 28, 2022

Release v1.6.0/v0.31.0 #2134

Merged

MrAlias mentioned this pull request Apr 26, 2022

Return metric SDK testing using metrictest #2224

Merged

thaJeztah mentioned this pull request Mar 8, 2023

vendor: github.com/containerd/containerd v1.7.0-rc.2 moby/moby#44530

Closed

pellared added this to the untracked milestone Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Instrumentation to metrics v0.28.0#1977

Update Instrumentation to metrics v0.28.0#1977
MadVikingGod merged 10 commits intoopen-telemetry:mainfrom
MadVikingGod:mvg/update-metric-api

MadVikingGod commented Mar 24, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Mar 24, 2022 •

edited

Loading

Uh oh!

Uh oh!

Aneurysm9 Mar 24, 2022

Uh oh!

MadVikingGod Mar 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MadVikingGod Mar 24, 2022

Uh oh!

MadVikingGod commented Mar 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MadVikingGod commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Aneurysm9 Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

MadVikingGod Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MadVikingGod Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

MadVikingGod commented Mar 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MadVikingGod commented Mar 24, 2022 •

edited

Loading

codecov Bot commented Mar 24, 2022 •

edited

Loading