Increase max size for signatures in speed.c#178
Increase max size for signatures in speed.c#178baentsch merged 3 commits intoopen-quantum-safe:OQS-OpenSSL_1_1_1-stablefrom
Conversation
baentsch
left a comment
There was a problem hiding this comment.
I'm dumbfounded. Thanks very much: It looks like this indeed fixes the error. A full speed run with this patch doesn't SIGSEGV any more. Something else with picnic must have changed, though, as the error couldn't be triggered any more (before applying this patch!) by running picnic alone (as was the case when I created the issue). Whatever, case closed!
Before merging, would you please remove the two references to OPENSSL_NO_CLEANUP to re-activate full testing (one in apps/speed.c and one in oqs_test/scripts/do_openssl-speed.sh)? Thanks in advance.
The speed tool crashed for me at different point on different machines (sometimes during signing, sometime during verification). Probably depends on the state of the heap, which could vary I suppose from machine to machine, debug vs. release, etc.
Will do. |
|
@baentsch, in |
|
@christianpaquin No, such code would not be necessary: The last command run provides the exit code for the whole script: If it fails, the script fails (and vice versa). But it also shouldn't hurt. |
baentsch
left a comment
There was a problem hiding this comment.
do_openssl-speed.sh redone anyway.
Currently Github is recording a conflict with do_openssl-speed.sh. Will someone be rebasing to resolve the conflict before merging? |
|
Easiest in my eyes would be probably for @christianpaquin to just remove |
This reverts commit 9c9a771. Reverting changes to do_openssl-speed.sh as it now conflicts with testing overhaul PR.
|
Done. |
Increases max signature sizes for speed tests to 35000 (enough for picnicl1fs). Test code is hard to read, but it uses the last value of
lengths_listarray to allocate the signature buffer in the OQS tests. We'll need to update this value as we add algs with larger sigs.Fixes issue #159.