report: Fetching latest OPA release version from GH#7756
Merged
johanfylling merged 5 commits intoopen-policy-agent:mainfrom Jul 8, 2025
Merged
report: Fetching latest OPA release version from GH#7756johanfylling merged 5 commits intoopen-policy-agent:mainfrom
johanfylling merged 5 commits intoopen-policy-agent:mainfrom
Conversation
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
johanfylling
commented
Jul 7, 2025
|
|
||
| gatherers map[string]Gatherer | ||
| gatherersMtx sync.Mutex | ||
| type Reporter interface { |
Contributor
Author
There was a problem hiding this comment.
Making Reporter an interface might be overkill as it's pretty unlikely someone relies on this, but this way it's possible to swap in a bespoke reporter for posting meta.
The type change is however a breaking change to report.New(), but as said above: very unlikely someone is using this today.
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
srenatus
approved these changes
Jul 7, 2025
Contributor
srenatus
left a comment
There was a problem hiding this comment.
We'll never know if someone implemented their own telemetry endpoint... but if so, they can use the old report package's code in their project, I suppose...so it's probably OK.
LGTM 🚀
internal/report/report.go
Outdated
| "id": id, | ||
| "version": version.Version, | ||
| } | ||
| func New(_ string, opts Options) (Reporter, error) { |
Contributor
There was a problem hiding this comment.
Since we're breaking back-compat anyways, why not drop the first parameter? 😉
| body map[string]any | ||
| client rest.Client | ||
|
|
||
| gatherers map[string]Gatherer |
Contributor
There was a problem hiding this comment.
Is there some more gatherer-related code we can get rid off now? 🤔
Contributor
Thought about it again, it'll be a hassle if someone did that.... Let's hope nobody did 🙃 |
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Contributor
|
Fixes #7739 |
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 7, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/opa
that referenced
this pull request
Jan 8, 2026
Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
that referenced
this pull request
Jan 8, 2026
* runtime: Correct naming of version checking code Rename telemetry functionality to version checking to accurately reflect current behavior following #7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com> * Make WithTelemetryGatherers a no-op Deprecate WithTelemetryGatherers since telemetry gathering has been removed. The function now returns a no-op to maintain API compatibility without breaking existing code that might uses it. Signed-off-by: Charlie Egan <charlie_egan@apple.com> --------- Signed-off-by: Charlie Egan <charlie_egan@apple.com>
alex60217101990
pushed a commit
to alex60217101990/opa
that referenced
this pull request
Jan 10, 2026
…t#8191) * runtime: Correct naming of version checking code Rename telemetry functionality to version checking to accurately reflect current behavior following open-policy-agent#7756. The system only checks GitHub releases for version updates without sending any data about the OPA instance and so the privacy docs have been updated too. Signed-off-by: Charlie Egan <charlie_egan@apple.com> * Make WithTelemetryGatherers a no-op Deprecate WithTelemetryGatherers since telemetry gathering has been removed. The function now returns a no-op to maintain API compatibility without breaking existing code that might uses it. Signed-off-by: Charlie Egan <charlie_egan@apple.com> --------- Signed-off-by: Charlie Egan <charlie_egan@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of telemetry server.