Skip to content

[Feature] Add --show-dir option behavior on multi-gpu testing#583

Open
mikigom wants to merge 11 commits intoopen-mmlab:masterfrom
mikigom:master
Open

[Feature] Add --show-dir option behavior on multi-gpu testing#583
mikigom wants to merge 11 commits intoopen-mmlab:masterfrom
mikigom:master

Conversation

@mikigom
Copy link
Copy Markdown

@mikigom mikigom commented Jun 4, 2021

This modification is for multi-gpu testing to support behavior of --show-dir option.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 4, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Junjun2016
✅ mikigom
❌ root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2021

Codecov Report

Merging #583 (82f735a) into master (ee66167) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

❗ Current head 82f735a differs from pull request most recent head e8cbe7c. Consider uploading reports for the commit e8cbe7c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   85.37%   85.10%   -0.27%     
==========================================
  Files         107      107              
  Lines        5847     5829      -18     
  Branches      960      954       -6     
==========================================
- Hits         4992     4961      -31     
- Misses        673      685      +12     
- Partials      182      183       +1     
Flag Coverage Δ
unittests 85.09% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/test.py 26.43% <0.00%> (-4.23%) ⬇️
mmseg/models/backbones/hrnet.py 82.45% <0.00%> (-0.88%) ⬇️
mmseg/datasets/pipelines/transforms.py 97.12% <0.00%> (-0.87%) ⬇️
mmseg/models/builder.py 91.30% <0.00%> (-0.70%) ⬇️
mmseg/models/necks/fpn.py 53.94% <0.00%> (-0.60%) ⬇️
mmseg/models/backbones/unet.py 94.87% <0.00%> (-0.05%) ⬇️
mmseg/models/backbones/vit.py 84.84% <0.00%> (ø)
mmseg/models/backbones/swin.py 86.89% <0.00%> (ø)
mmseg/models/backbones/resnet.py 99.28% <0.00%> (ø)
mmseg/models/necks/multilevel_neck.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee66167...e8cbe7c. Read the comment docs.

@xvjiarui
Copy link
Copy Markdown
Collaborator

xvjiarui commented Jun 4, 2021

Hi @mikigom
Thanks for the nice feature. Could you please fix the lint error to pass the CI?

@mikigom
Copy link
Copy Markdown
Author

mikigom commented Jun 10, 2021

Hi @mikigom
Thanks for the nice feature. Could you please fix the lint error to pass the CI?

I fixed the lint error as you said :)

@Junjun2016
Copy link
Copy Markdown
Collaborator

Hi @mikigom
Sorry for the late reply.
Could you please fix the lint error again?

@Junjun2016
Copy link
Copy Markdown
Collaborator

Hi @mikigom
We will test and review it ASAP!

@Junjun2016
Copy link
Copy Markdown
Collaborator

Hi @mikigom
It is better to checkout a new branch for PR instead of the master.
I have created a PR to your folked mmsegmentation repo.

@Junjun2016
Copy link
Copy Markdown
Collaborator

Hi @mikigom
Could you please fix the conflicts?

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* WIP: flax FlaxDiffusionPipeline & FlaxStableDiffusionPipeline

* todo comment

* Fix imports

* Fix imports

* add dummies

* Fix empty init

* make pipeline work

* up

* Allow dtype to be overridden on model load.

This may be a temporary solution until open-mmlab#567 is addressed.

* Convert params to bfloat16 or fp16 after loading.

This deals with the weights, not the model.

* Use Flax schedulers (typing, docstring)

* PNDM: replace control flow with jax functions.

Otherwise jitting/parallelization don't work properly as they don't know
how to deal with traced objects.

I temporarily removed `step_prk`.

* Pass latents shape to scheduler set_timesteps()

PNDMScheduler uses it to reserve space, other schedulers will just
ignore it.

* Wrap model imports inside availability checks.

* Optionally return state in from_config.

Useful for Flax schedulers.

* Do not convert model weights to dtype.

* Re-enable PRK steps with functional implementation.

Values returned still not verified for correctness.

* Remove left over has_state var.

* make style

* Apply suggestion list -> tuple

Co-authored-by: Suraj Patil <surajp815@gmail.com>

* Apply suggestion list -> tuple

Co-authored-by: Suraj Patil <surajp815@gmail.com>

* Remove unused comments.

* Use zeros instead of empty.

Co-authored-by: Mishig Davaadorj <dmishig@gmail.com>
Co-authored-by: Mishig Davaadorj <mishig.davaadorj@coloradocollege.edu>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Co-authored-by: Suraj Patil <surajp815@gmail.com>
@OpenMMLab-Coodinator
Copy link
Copy Markdown

Hi @mikigom !We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) , where you can share your experiences, ideas, and build connections with like-minded peers.

To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

michaelzhang-ai pushed a commit to michaelzhang-ai/mmsegmentation that referenced this pull request Mar 22, 2024
* fix mmdet warnings

* add unit test

* remove mmcv-full uninstall warnings

* add changelog

* remove rebundent changelog of refactor unittest

* fix conflict

* fix warnings of mmcv-full uninstalled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants