Use MMCV's EvalHook in MMSegmentation#438
Merged
xvjiarui merged 11 commits intoopen-mmlab:masterfrom May 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 86.51% 86.60% +0.09%
==========================================
Files 97 99 +2
Lines 4967 5152 +185
Branches 806 833 +27
==========================================
+ Hits 4297 4462 +165
- Misses 517 533 +16
- Partials 153 157 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
unit test failed. |
Collaborator
|
We may directly inherit from mmcv instead of define all of them. |
xvjiarui
approved these changes
May 5, 2021
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* mmcv eval hook * mmcv evalhook compatible * add warnings * inherit from base class * fix unitest * adapt to mmcv 1.3.1 * fixed unittest * set by_epoch=False * fixed efficient test * update docstring Co-authored-by: Jiarui XU <xvjiarui0826@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply EvalHook and DistEvalHook implemented in MMCV open-mmlab/mmcv#739 .