[Enhancement] Add win-ci#1296
Merged
MeowZheng merged 6 commits intoopen-mmlab:masterfrom Feb 22, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.02%
==========================================
Files 130 131 +1
Lines 7560 7599 +39
Branches 1258 1264 +6
==========================================
+ Hits 6821 6858 +37
Misses 531 531
- Partials 208 210 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MeowZheng
reviewed
Feb 17, 2022
MeowZheng
approved these changes
Feb 17, 2022
MeowZheng
reviewed
Feb 18, 2022
requirements/runtime.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| matplotlib | |||
| numpy | |||
| opencv-python>=3 | |||
Collaborator
There was a problem hiding this comment.
From mmcv experiments, they don't recommend adding opencv in requirements as opencv have 4 versions and there is a conflict between them
Contributor
Author
There was a problem hiding this comment.
Delete opencv-python>=3 would raise error. Windows system needs cv2. So I added it back.
ZhimingNJ
pushed a commit
to AetrexTechnology/mmsegmentation
that referenced
this pull request
Jun 29, 2022
* [Enhancement] Add win-ci * add timm in win unittest * remove mmflow with mmseg in win unittest * remove opencv-python in requirements * add opencv2 back * move opencv installation into build.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add win-ci in .github/workflows/build.yml
ref pr: open-mmlab/mmagic#732, open-mmlab/mmflow#92.