[Fix] Improve MultiImageMixDataset unittests coverage#1197
Merged
MeowZheng merged 24 commits intoopen-mmlab:masterfrom Jan 22, 2022
lkm2835:dataset
Merged
[Fix] Improve MultiImageMixDataset unittests coverage#1197MeowZheng merged 24 commits intoopen-mmlab:masterfrom lkm2835:dataset
MeowZheng merged 24 commits intoopen-mmlab:masterfrom
lkm2835:dataset
Conversation
* remove dynamic_scale & add palette * modify retrieve_data_cfg method * modify retrieve_data_cfg func
Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
+ Coverage 90.10% 90.21% +0.10%
==========================================
Files 126 126
Lines 7430 7430
Branches 1239 1239
==========================================
+ Hits 6695 6703 +8
+ Misses 530 523 -7
+ Partials 205 204 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
Hi @lkm2835 |
Junjun2016
approved these changes
Jan 12, 2022
MengzhangLI
approved these changes
Jan 15, 2022
MeowZheng
approved these changes
Jan 17, 2022
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
* Fix typo in usage example * original MultiImageMixDataset code in mmdet * Add MultiImageMixDataset unittests in test_dataset_wrapper * fix lint error * fix value name ann_file to ann_dir * modify retrieve_data_cfg (#1) * remove dynamic_scale & add palette * modify retrieve_data_cfg method * modify retrieve_data_cfg func * fix error * improve the unittests coverage * fix unittests error * Dataset (#2) * add cfg-options * Add unittest in test_build_dataset * add blank line * add blank line * add a blank line Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com> * [Fix] Add MultiImageMixDataset unittests Co-authored-by: Younghoon-Lee <72462227+Younghoon-Lee@users.noreply.github.com> Co-authored-by: MeowZheng <meowzheng@outlook.com> Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RandomMosaic: line 1129 ~ 1130
MultiImageMixDataset: line 249 ~ 261
Improved unittest coverage
Modification
tests/test_data/test_dataset.pyAdd RandomMosaic in pipeline
Fix typo:
data_infos->img_infos