[Feature] Support ISPRS Potsdam Dataset. by Junjue-Wang · Pull Request #1097 · open-mmlab/mmsegmentation

Junjue-Wang · 2021-12-01T13:54:29Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Enhance the dataset diversity for MMSegmentation in Remote Sensing.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
The documentation has been modified accordingly, like docstring or example tutorials.

MengzhangLI · 2021-12-01T14:09:37Z

Hi, @Junjue-Wang Thanks for your nice work.

We would review this pr ASAP.

Best,

codecov · 2021-12-01T14:46:14Z

Codecov Report

Merging #1097 (c161c14) into master (6c3e63e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   90.10%   90.13%   +0.02%     
==========================================
  Files         126      127       +1     
  Lines        7430     7447      +17     
  Branches     1239     1240       +1     
==========================================
+ Hits         6695     6712      +17     
  Misses        530      530              
  Partials      205      205

Flag	Coverage Δ
unittests	`90.13% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmseg/core/evaluation/class_names.py	`90.90% <100.00%> (+2.02%)`	⬆️
mmseg/datasets/__init__.py	`100.00% <100.00%> (ø)`
mmseg/datasets/potsdam.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3e63e...c161c14. Read the comment docs.

Junjun2016 · 2021-12-01T15:27:04Z

Hi @Junjue-Wang
Thanks for your contribution again.
Please fix the lint error and refine the PR message.

tools/convert_datasets/potsdam.py

Junjue-Wang · 2021-12-05T11:30:33Z

@MengzhangLI I have already added the vaihingen api

MengzhangLI · 2021-12-05T12:02:08Z

Copy that. I would review & test your code in the next few days.

Thank you.

mmseg/datasets/isprs.py

configs/_base_/datasets/vaihingen.py

tools/convert_datasets/vaihingen.py

configs/_base_/datasets/vaihingen.py

tools/convert_datasets/potsdam.py

configs/pspnet/pspnet.yml

MeowZheng

LGTM

docs/en/dataset_prepare.md

docs/zh_cn/dataset_prepare.md

* add isprs potsdam dataset * add isprs dataset configs * fix lint error * fix potsdam conversion bug * fix error in potsdam class * fix error in potsdam class * add vaihingen dataset * add vaihingen dataset * add vaihingen dataset * fix some description errors. * fix some description errors. * fix some description errors. * upload models & logs of Potsdam * remove vaihingen and add unit test * add chinese readme * add pseudodataset * use mmcv and add class_names * use f-string * add new dataset unittest * add docstring and remove global variables args * fix metafile error in PSPNet * fix pretrained value * Add dataset info * fix typo Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

Junjue-Wang added 2 commits December 1, 2021 21:51

add isprs potsdam dataset

8bf8bfd

add isprs dataset configs

5f03fd8

Junjun2016 reviewed Dec 1, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

fix lint error

442c980

Junjun2016 reviewed Dec 1, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 1, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 1, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

MengzhangLI added 3 commits December 2, 2021 00:49

fix potsdam conversion bug

a664083

fix error in potsdam class

e88d89f

fix error in potsdam class

0637eae

MengzhangLI added the WIP Work in process label Dec 2, 2021

MengzhangLI self-assigned this Dec 2, 2021

Junjue-Wang added 2 commits December 5, 2021 19:25

add vaihingen dataset

e32dbda

add vaihingen dataset

8c10cfa

add vaihingen dataset

0958ea0

Junjun2016 reviewed Dec 5, 2021

View reviewed changes

mmseg/datasets/isprs.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 5, 2021

View reviewed changes

configs/_base_/datasets/vaihingen.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 5, 2021

View reviewed changes

tools/convert_datasets/vaihingen.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 5, 2021

View reviewed changes

tools/convert_datasets/vaihingen.py Outdated Show resolved Hide resolved

Junjun2016 reviewed Dec 5, 2021

View reviewed changes

tools/convert_datasets/vaihingen.py Outdated Show resolved Hide resolved

Junjue-Wang and others added 5 commits December 5, 2021 20:26

fix some description errors.

e173146

fix some description errors.

1e341bc

fix some description errors.

0b3e332

upload models & logs of Potsdam

5737f0c

fix conflict

0a27403

add new dataset unittest

3153667

MeowZheng reviewed Dec 29, 2021

View reviewed changes

configs/_base_/datasets/vaihingen.py Outdated Show resolved Hide resolved

MeowZheng reviewed Dec 29, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

MeowZheng reviewed Dec 29, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

MeowZheng reviewed Dec 29, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

MeowZheng reviewed Dec 29, 2021

View reviewed changes

tools/convert_datasets/potsdam.py Outdated Show resolved Hide resolved

add docstring and remove global variables args

e8cba9d

MeowZheng reviewed Jan 7, 2022

View reviewed changes

configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved

MeowZheng reviewed Jan 7, 2022

View reviewed changes

configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved

MeowZheng reviewed Jan 7, 2022

View reviewed changes

configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved

MeowZheng reviewed Jan 7, 2022

View reviewed changes

configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved

fix metafile error in PSPNet

4867612

MeowZheng approved these changes Jan 10, 2022

View reviewed changes

MengzhangLI requested a review from xvjiarui January 10, 2022 17:22

fix conflict and delete .format folder

f6c51d7

Junjun2016 approved these changes Jan 12, 2022

View reviewed changes

MeowZheng requested review from RockeyCoss and linfangjian01 January 12, 2022 07:08

MengzhangLI approved these changes Jan 12, 2022

View reviewed changes

fix pretrained value

1de69b7

MengzhangLI mentioned this pull request Jan 15, 2022

Loss is very low, but the validation set accuracy is poor #1204

Closed

Add dataset info

26da577

MeowZheng reviewed Jan 17, 2022

View reviewed changes

docs/en/dataset_prepare.md Show resolved Hide resolved

MeowZheng reviewed Jan 17, 2022

View reviewed changes

docs/zh_cn/dataset_prepare.md Show resolved Hide resolved

fix typo

c161c14

Junjun2016 approved these changes Jan 18, 2022

View reviewed changes

MeowZheng merged commit b997a13 into open-mmlab:master Jan 18, 2022

MengzhangLI removed WIP Work in process Merging PR waited for merging labels Jan 18, 2022

Conversation

Junjue-Wang commented Dec 1, 2021

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Uh oh!

MengzhangLI commented Dec 1, 2021

Uh oh!

codecov bot commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Junjun2016 commented Dec 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Junjue-Wang commented Dec 5, 2021

Uh oh!

MengzhangLI commented Dec 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MeowZheng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 1, 2021 •

edited

Loading