Skip to content

Update requirements#319

Merged
sunnyxiaohu merged 1 commit intoopen-mmlab:dev-1.xfrom
HIT-cwh:fix_engine_version
Oct 13, 2022
Merged

Update requirements#319
sunnyxiaohu merged 1 commit intoopen-mmlab:dev-1.xfrom
HIT-cwh:fix_engine_version

Conversation

@HIT-cwh
Copy link
Copy Markdown
Collaborator

@HIT-cwh HIT-cwh commented Oct 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HIT-cwh HIT-cwh changed the base branch from master to dev-1.x October 13, 2022 08:40
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Base: 82.02% // Head: 82.86% // Increases project coverage by +0.84% 🎉

Coverage data is based on head (95f9837) compared to base (f98ac34).
Patch coverage: 89.13% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-1.x     #319      +/-   ##
===========================================
+ Coverage    82.02%   82.86%   +0.84%     
===========================================
  Files          182      190       +8     
  Lines         7538     8336     +798     
  Branches      1150     1298     +148     
===========================================
+ Hits          6183     6908     +725     
- Misses        1132     1168      +36     
- Partials       223      260      +37
Flag Coverage Δ
unittests 82.86% <89.13%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrazor/engine/runner/slimmable_val_loop.py 37.03% <0.00%> (ø)
...tectures/dynamic_ops/mixins/dynamic_conv_mixins.py 91.66% <ø> (ø)
...architectures/dynamic_ops/mixins/dynamic_mixins.py 88.41% <ø> (ø)
...mrazor/models/mutators/channel_mutator/__init__.py 100.00% <ø> (ø)
mmrazor/structures/graph/channel_graph.py 80.00% <80.00%> (ø)
mmrazor/structures/graph/channel_nodes.py 80.31% <80.31%> (ø)
...s/mutables/mutable_channel/base_mutable_channel.py 80.95% <80.95%> (ø)
...models/mutators/channel_mutator/channel_mutator.py 86.71% <86.06%> (-13.29%) ⬇️
...bles/mutable_channel/units/mutable_channel_unit.py 86.39% <86.39%> (ø)
mmrazor/structures/graph/channel_modules.py 86.51% <86.51%> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sunnyxiaohu sunnyxiaohu self-requested a review October 13, 2022 09:23
@sunnyxiaohu sunnyxiaohu merged commit 0409adc into open-mmlab:dev-1.x Oct 13, 2022
@HIT-cwh HIT-cwh deleted the fix_engine_version branch October 13, 2022 11:24
gaoyang07 pushed a commit to gaoyang07/mmrazor that referenced this pull request Oct 19, 2022
@HIT-cwh
Update requirements (open-mmlab#319)
6c873c6 
update mmengine version
gaoyang07 pushed a commit to gaoyang07/mmrazor that referenced this pull request Oct 19, 2022
@HIT-cwh
Update requirements (open-mmlab#319)
bf4b4ed 
update mmengine version
humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
@RunningLeon
update backend docs (open-mmlab#319)
f76ac64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pppppM pppppM pppppM approved these changes

+1 more reviewer

@sunnyxiaohu sunnyxiaohu sunnyxiaohu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HIT-cwh @sunnyxiaohu @pppppM