Skip to content

[Feature] Add DFAD algorithm#247

Merged
sunnyxiaohu merged 1 commit intoopen-mmlab:dev-1.xfrom
wilxy:dfad
Aug 25, 2022
Merged

[Feature] Add DFAD algorithm#247
sunnyxiaohu merged 1 commit intoopen-mmlab:dev-1.xfrom
wilxy:dfad

Conversation

@wilxy
Copy link
Copy Markdown
Contributor

@wilxy wilxy commented Aug 24, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add a data-free distillation algorithm named Data-Free Adversarial Distillation (DFAD).

Modification

1.Add DFAD algorithm.
2.Add L1Loss and its UT.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2022

Codecov Report

Merging #247 (c543efc) into dev-1.x (876b2ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           dev-1.x    #247      +/-   ##
==========================================
- Coverage     0.44%   0.44%   -0.01%     
==========================================
  Files          163     164       +1     
  Lines         6545    6564      +19     
  Branches      1068    1069       +1     
==========================================
  Hits            29      29              
- Misses        6511    6530      +19     
  Partials         5       5              
Flag Coverage Δ
unittests 0.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrazor/models/losses/__init__.py 0.00% <0.00%> (ø)
mmrazor/models/losses/l1_loss.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sunnyxiaohu
Copy link
Copy Markdown
Contributor

it's ok to me

@sunnyxiaohu sunnyxiaohu merged commit f3b964c into open-mmlab:dev-1.x Aug 25, 2022
pprp pushed a commit to pprp/mmrazor that referenced this pull request Aug 28, 2022
1.Add DFAD algorithm. 2.Add L1Loss and its UT.
@wilxy wilxy deleted the dfad branch August 29, 2022 11:14
humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants