Skip to content

[feature] add Factor Transfer#237

Merged
sunnyxiaohu merged 12 commits intoopen-mmlab:dev-1.xfrom
fpshuang:gml-ft
Aug 23, 2022
Merged

[feature] add Factor Transfer#237
sunnyxiaohu merged 12 commits intoopen-mmlab:dev-1.xfrom
fpshuang:gml-ft

Conversation

@fpshuang
Copy link
Copy Markdown
Contributor

@fpshuang fpshuang commented Aug 18, 2022 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Factor Transfer KD algo

Modification

  • add FT components
  • add comprehensive UTs
  • add FT experiment on CIFAR10

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

huangpengsheng added 2 commits August 17, 2022 17:11
@fpshuang fpshuang marked this pull request as draft August 18, 2022 13:00
@fpshuang fpshuang changed the title [feature] add Factor Transfer WIP: [feature] add Factor Transfer Aug 18, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #237 (3076083) into dev-1.x (4b3f8ab) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 3076083 differs from pull request most recent head a90ae30. Consider uploading reports for the commit a90ae30 to get more accurate results

@@            Coverage Diff             @@
##           dev-1.x    #237      +/-   ##
==========================================
- Coverage     0.44%   0.44%   -0.01%     
==========================================
  Files          159     161       +2     
  Lines         6454    6509      +55     
  Branches      1059    1064       +5     
==========================================
  Hits            29      29              
- Misses        6420    6475      +55     
  Partials         5       5
Flag Coverage Δ
unittests 0.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mrazor/models/architectures/connectors/__init__.py 0.00% <0.00%> (ø)
...itectures/connectors/factor_transfer_connectors.py 0.00% <0.00%> (ø)
mmrazor/models/losses/__init__.py 0.00% <0.00%> (ø)
mmrazor/models/losses/factor_transfer_loss.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpshuang fpshuang requested a review from pppppM August 19, 2022 07:49
@fpshuang fpshuang marked this pull request as ready for review August 19, 2022 07:50
@fpshuang fpshuang changed the title WIP: [feature] add Factor Transfer [feature] add Factor Transfer Aug 19, 2022
@fpshuang fpshuang requested a review from wilxy August 19, 2022 08:44
@sunnyxiaohu
Copy link
Copy Markdown
Contributor

sunnyxiaohu commented Aug 19, 2022 •
edited
Loading

update docstrings and type hint.

@wilxy
Copy link
Copy Markdown
Contributor

wilxy commented Aug 23, 2022

Resolve the conflicts.

@fpshuang
Copy link
Copy Markdown
Contributor Author

fpshuang commented Aug 23, 2022

https://aicarrier.feishu.cn/drive/folder/fldcnBVCuhmTnlOb6XFW7SYUVUh?from=space_persnoal_filelist

CI snapshot

@fpshuang
Copy link
Copy Markdown
Contributor Author

fpshuang commented Aug 23, 2022

Resolve the conflicts.

done

sunnyxiaohu
sunnyxiaohu reviewed Aug 23, 2022
View reviewed changes
mmrazor/models/architectures/connectors/factor_transfer_connectors.py
return t_feat_rec

def forward(self, x):
"""Omitted."""
Copy link
Copy Markdown
Contributor

@sunnyxiaohu sunnyxiaohu Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update docstring

@sunnyxiaohu sunnyxiaohu merged commit afb95a4 into open-mmlab:dev-1.x Aug 23, 2022
humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
@RunningLeon
Support YOLOX with TensorRT (open-mmlab#237)
3b97f64 
* support trt

* fix test
@openmmlab-bot
Copy link
Copy Markdown
Collaborator

openmmlab-bot commented Mar 31, 2023

Dear FreakieHuang ,
First of all, we want to express our gratitude for your significant PR in the MMRazor project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards！ @FreakieHuang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pppppM pppppM Awaiting requested review from pppppM

@wilxy wilxy Awaiting requested review from wilxy

@spynccat spynccat Awaiting requested review from spynccat

@aptsunny aptsunny Awaiting requested review from aptsunny

@gaoyang07 gaoyang07 Awaiting requested review from gaoyang07

@HIT-cwh HIT-cwh Awaiting requested review from HIT-cwh

@humu789 humu789 Awaiting requested review from humu789

1 more reviewer

@sunnyxiaohu sunnyxiaohu sunnyxiaohu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fpshuang @sunnyxiaohu @wilxy @openmmlab-bot