[Fix] update required mmcv version to `>=1.3.13` by pppppM · Pull Request #23 · open-mmlab/mmrazor

pppppM · 2021-12-24T14:35:57Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The revert_sync_batchnorm used in DetNAS is a new feature in mmcv=1.3.13, so we need update required mmcv version(#20)

Modification

requirements/mminstall.txt
update required mmcv version from mmcv>=1.3.8,<=1.50 to mmcv>1.3.13,<=1.50

BC-breaking (Optional)

No

Use cases (Optional)

No

Checklist

Before PR:

Pre-commit or other linting tools are used to fix the potential lint issues.
Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
CLA has been signed and all committers have signed the CLA in this PR.

codecov · 2021-12-24T14:39:23Z

Codecov Report

Merging #23 (c713e18) into master (3d36290) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files          81       81           
  Lines        2941     2941           
  Branches      544      544           
=======================================
  Hits         1635     1635           
  Misses       1231     1231           
  Partials       75       75

Flag	Coverage Δ
unittests	`55.59% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d36290...c713e18. Read the comment docs.

* update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo

* Base Framework (open-mmlab#24) * Base Framework * [Feature] Add loss * [Feature] Add op (open-mmlab#4) * [Feature] Add mutator (open-mmlab#3) * [Feature] Add mutable (open-mmlab#2) * [Feature] Add architecture (open-mmlab#1) * [Docs] Add Docs (open-mmlab#6) * add docs * fix known_third_party Co-authored-by: qiufeng <qiufeng3217@gmail.com> * update docs (open-mmlab#12) Co-authored-by: qiufeng <qiufeng3217@gmail.com> * [Docs] Add README (open-mmlab#10) * add readme * refactor readme * add logo * update release time Co-authored-by: qiufeng <qiufeng3217@gmail.com> * [Docs] Add Resources (open-mmlab#11) * add resources * fix known_third_party * fix known_third_party * fix known_third_party * refactor resources Co-authored-by: qiufeng <qiufeng3217@gmail.com> * add pytest (open-mmlab#18) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add utils (open-mmlab#17) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add distillers (open-mmlab#16) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add pruners (open-mmlab#15) Co-authored-by: caoweihan <caoweihan@sensetime.com> * fix bug * update docstring (open-mmlab#20) * Prepare for open source (open-mmlab#23) * update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo Co-authored-by: humu789 <humu@pjlab.org.cn> Co-authored-by: humu789 <88702197+humu789@users.noreply.github.com> Co-authored-by: qiufeng <44188071+wutongshenqiu@users.noreply.github.com> Co-authored-by: qiufeng <qiufeng3217@gmail.com> Co-authored-by: whcao <41630003+HIT-cwh@users.noreply.github.com> Co-authored-by: caoweihan <caoweihan@sensetime.com> * fix readme and pre-commit * rename tutorials * fix a bug * pass lint Co-authored-by: pppppM <67539920+pppppM@users.noreply.github.com> Co-authored-by: humu789 <humu@pjlab.org.cn> Co-authored-by: humu789 <88702197+humu789@users.noreply.github.com> Co-authored-by: qiufeng <44188071+wutongshenqiu@users.noreply.github.com> Co-authored-by: qiufeng <qiufeng3217@gmail.com> Co-authored-by: caoweihan <caoweihan@sensetime.com>

* update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo

* Base Framework (open-mmlab#24) * Base Framework * [Feature] Add loss * [Feature] Add op (open-mmlab#4) * [Feature] Add mutator (open-mmlab#3) * [Feature] Add mutable (open-mmlab#2) * [Feature] Add architecture (open-mmlab#1) * [Docs] Add Docs (open-mmlab#6) * add docs * fix known_third_party Co-authored-by: qiufeng <qiufeng3217@gmail.com> * update docs (open-mmlab#12) Co-authored-by: qiufeng <qiufeng3217@gmail.com> * [Docs] Add README (open-mmlab#10) * add readme * refactor readme * add logo * update release time Co-authored-by: qiufeng <qiufeng3217@gmail.com> * [Docs] Add Resources (open-mmlab#11) * add resources * fix known_third_party * fix known_third_party * fix known_third_party * refactor resources Co-authored-by: qiufeng <qiufeng3217@gmail.com> * add pytest (open-mmlab#18) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add utils (open-mmlab#17) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add distillers (open-mmlab#16) Co-authored-by: caoweihan <caoweihan@sensetime.com> * add pruners (open-mmlab#15) Co-authored-by: caoweihan <caoweihan@sensetime.com> * fix bug * update docstring (open-mmlab#20) * Prepare for open source (open-mmlab#23) * update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo Co-authored-by: humu789 <humu@pjlab.org.cn> Co-authored-by: humu789 <88702197+humu789@users.noreply.github.com> Co-authored-by: qiufeng <44188071+wutongshenqiu@users.noreply.github.com> Co-authored-by: qiufeng <qiufeng3217@gmail.com> Co-authored-by: whcao <41630003+HIT-cwh@users.noreply.github.com> Co-authored-by: caoweihan <caoweihan@sensetime.com> * fix readme and pre-commit * rename tutorials * fix a bug * pass lint Co-authored-by: pppppM <67539920+pppppM@users.noreply.github.com> Co-authored-by: humu789 <humu@pjlab.org.cn> Co-authored-by: humu789 <88702197+humu789@users.noreply.github.com> Co-authored-by: qiufeng <44188071+wutongshenqiu@users.noreply.github.com> Co-authored-by: qiufeng <qiufeng3217@gmail.com> Co-authored-by: caoweihan <caoweihan@sensetime.com>

[Fix] update required mmcv version to 1.3.13

c713e18

pppppM linked an issue Dec 24, 2021 that may be closed by this pull request

mmcv-full version in Requirements.txt maybe wrong #20

Closed

pppppM assigned pppppM and HIT-cwh Dec 24, 2021

humu789 assigned humu789 and pppppM and unassigned HIT-cwh and pppppM Dec 24, 2021

humu789 approved these changes Dec 24, 2021

View reviewed changes

pppppM merged commit 12f35a1 into open-mmlab:master Dec 24, 2021

pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022

Prepare for open source (open-mmlab#23)

bbcbbd4

* update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo

pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022

[Fix] update required mmcv version to 1.3.13 (open-mmlab#23)

1abedc0

pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022

Prepare for open source (open-mmlab#23)

e703ef9

* update MMRazor description * update Github action * add Mircosoft copyright * update requirements * fix a bug * fix a typo

pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022

[Fix] update required mmcv version to 1.3.13 (open-mmlab#23)

db83dce

humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023

add TRT8 support (open-mmlab#23)

6ff8e96

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] update required mmcv version to `>=1.3.13`#23

[Fix] update required mmcv version to `>=1.3.13`#23
pppppM merged 1 commit intoopen-mmlab:masterfrom
pppppM:update_mmcv_version

pppppM commented Dec 24, 2021 •

edited

Loading

Uh oh!

codecov bot commented Dec 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pppppM commented Dec 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Uh oh!

codecov bot commented Dec 24, 2021

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pppppM commented Dec 24, 2021 •

edited

Loading